Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Token based Highlighting vs. Self Containing Extensions #120

Closed
cdietrich opened this issue Nov 9, 2016 · 4 comments
Closed

Token based Highlighting vs. Self Containing Extensions #120

cdietrich opened this issue Nov 9, 2016 · 4 comments

Comments

@cdietrich
Copy link

Since (as given by VSCode as example) textMate Grammars seem to be a defacto standard for doing token/grammar based highlighting we have a "thing" in lsp that prevents us from language servers beeing self contained. we always need a side channel to provide the text mate grammars as vscode does it through the configuration in package.json.

it would be nice to have a service in the protocol that allows the servers to deliver the grammars to the client or alternatively a service that does grammar based highlighting server side.

@mickaelistria
Copy link

I believe it's a duplicate of #18.

@cdietrich
Copy link
Author

no i explicitely mean a token based highlighting that is "fast" and may be done on client side

@svenefftinge
Copy link
Contributor

It is a duplicate of #7.

@dbaeumer
Copy link
Member

Thanks @svenefftinge. It is a dup of #7. I think if we open up the protocol for sematic classification then we can also support syntax classification. However syntax classification has the pre-requisite that it has to be fast and accurate during typing. So this must be defined in a clever way.

Dups #7 and #18. Lets continue the discussion in #18.

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 21, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants