Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question regard completion resolve and resolve capability #1669

Closed
jdneo opened this issue Feb 14, 2023 · 2 comments
Closed

Question regard completion resolve and resolve capability #1669

jdneo opened this issue Feb 14, 2023 · 2 comments

Comments

@jdneo
Copy link
Member

jdneo commented Feb 14, 2023

The spec says:

Since 3.16.0 the client can signal that it can resolve more properties lazily. This is done using the completionItem#resolveSupport client capability which lists all properties that can be filled in during a ‘completionItem/resolve’ request

And then follows

All other properties (usually sortText, filterText, insertText and textEdit) must be provided in the textDocument/completion response and must not be changed during resolve.

Can I understand this as: All other properties can be updated during resolve except for sortText, filterText, insertText and textEdit.

In other words, sortText, filterText, insertText and textEdit cannot be set into the resolve support capabilities?

@dbaeumer
Copy link
Member

Not fully, this is why the spec says usually. Clients would be allowed to make all properties lazy but that will not work well. So usually clients need sortText, filterText, insertText and textEdit to do some reasonable rendering of the items in the UI.

Hope that clarifies.

@jdneo
Copy link
Member Author

jdneo commented Feb 14, 2023

Thank you for the answer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants