Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signal the client a refactoring failed #1988

Open
fm-117 opened this issue Jul 22, 2024 · 0 comments
Open

Signal the client a refactoring failed #1988

fm-117 opened this issue Jul 22, 2024 · 0 comments
Labels
commands feature-request Request for new features or functionality workspace edit
Milestone

Comments

@fm-117
Copy link

fm-117 commented Jul 22, 2024

In my understanding of the refactorings in LSP, there is no dedicated property/notification for the server to signal the client that the refactoring failed. The server can reject a workspace/executeCommand request for example when the parameters are invalid but after that, the server must compute the edits and is expected to send a workspace/applyEdit request. However the ApplyWorkspaceEditParams type does not contain anything to report a problem that occured during the edits computation.

I'd like to have a int? code and string? message properties like in ResponseError directly on ApplyWorkspaceEditParams to describe failed or incomplete refactorings.

Note that the showMessage notification is not appropriate because the client has no info to correlate an incoming showMessage with a previously launched refactoring.

@dbaeumer dbaeumer added the feature-request Request for new features or functionality label Aug 6, 2024
@dbaeumer dbaeumer added this to the Backlog milestone Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
commands feature-request Request for new features or functionality workspace edit
Projects
None yet
Development

No branches or pull requests

2 participants