Bug: CornerRadius Inconsistency/Missing in ContentDialog/MessageDialog

[robloo]

Describe the bug
There is some inconsistency with the added corner radius in WinUI 2.2 styling (#659). The buttons in ContentDialog did not get a corner radius in all cases. Other dialog types probably have the same issue (MessageDialog).

Screenshots

(1) As you can see the button on the right has the radius, the button on the left does not.

Additonal Questions:
(2) When an item has keyboard focus like the buttons in the above image, should the added context border have a corner radius as well?
Edit: As answered below this is by design...

(3) AppBarButton doesn't have a CornerRadius. I actually think this looks better and should stay that way. However, was this and related AppBar controls missed in the discussion?
Edit: As answered below this is by design.

Version Info

Microsoft.UI.Xaml 2.2.190830001

Windows 10 version	Saw the problem?
May 2019 Update (18362)	Yes
October 2018 Update (17763)	N/A
April 2018 Update (17134)	N/A
Fall Creators Update (16299)	N/A
Creators Update (15063)	N/A

Device form factor	Saw the problem?
Desktop	Yes
Mobile	N/A
Xbox	N/A
Surface Hub	N/A
IoT	N/A

[jevansaks]

Buttons in ContentDialog is probably an oversight. Buttons in MessageDialog is owned by Windows and would be part of a future OS update.

AppBarButton ... i'm not sure. @chigy?

[chigy]

@robloo , @jevansaks
1 - A bug. All buttons are supposed to get rounded.
2 - Don't understand the question. If the question is if the keyboard focus should be rounded, then the answer is no. Not part of today's design.
3 - It is by design per "T-rule" when multiple items are next to each other and forms a T, it should not be rounded. Thus, we don't round list items nor grid items.

[robloo]

@chigy

2 - Don't understand the question. If the question is if the keyboard focus should be rounded, then the answer is no. Not part of today's design.

Yes, that is my question (should have said 'Focus'). Further annotated below:

3 - It is by design per "T-rule" when multiple items are next to each other and forms a T, it should not be rounded. Thus, we don't round list items nor grid items.

Makes a lot of sense and definitely visually it's the right call. Can this be added to docs some place so developers like myself are aware. We are going to have to know the design conventions with CornerRadius.

Probably here: https://docs.microsoft.com/en-us/windows/uwp/design/style/

I can add feedback to the document on GitHub if it will help.

[chigy]

@robloo , Yes, it is by design that we don't round and yes we plan on adding some note to that since as a developer you can round the corner as much as you like but they might not look good. Detail is still being worked out as to what to say and where, but early draft is here. https://github.com/microsoft/microsoft-ui-xaml-specs/blob/user/chigy/roundedcorner/active/RoundedCorner/roundedcorner.md

[chigy]

@robloo , can you please open a bug against # 1 so I can close this issue as resolved since the other two issues are actually by current design?

[robloo]

@chigy I will re-title this one. No need to make a new bug report.

[chigy]

Removing myself so it will appear at triage. Please consider fixing # 1 issue. FYI @jevansaks

[jevansaks]

Thanks @robloo! @kaiguo, FYI.

[ismaelestalayo]

Apart from the buttons that are not in the Selected state not having the CornerRadius set, the ContentDialog itself doesn't have it either:

[chigy]

@kaiguo , ContentDialog not having corner working was something to do with a bug that you were working through? Though I thought we shipped with corner rounded but the bug was about customization?

[robloo]

@kaiguo @chigy Are the buttons in the ContentDialog supposed to have a border brush? This doesn't match with the default button style.

Microsoft.UI.Xaml 2.3.191211002

This came up investigating #1764

[chigy]

@robloo , which version are you using because I am seeing the right behavior on my older Controls gallery (this one doesn't have rounded corner fixed) so did something get reverted when others got fixed?

[marcelwgn]

I am also seeing the right behavior on the latest commit on master of this repository. Following screenshot was taken inside the MUXControlsTestApp:

[robloo]

@chigy @chingucoding Ok, thanks for taking a look. This is a strange state my app is getting into then and it looks like it's tied with #1764. Since the style is correct for you, I won't worry about it here.

[robloo]

Update: The border on the buttons in the content dialog was a bug on my part. Sorry for that!

[kaiguo]

Update: The border on the buttons in the content dialog was a bug on my part. Sorry for that!

Thanks for letting us know.