-
Notifications
You must be signed in to change notification settings - Fork 675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal: Form Control Styles - Consistent to Fluent UI and FastDNA (Xbox too?) #2259
Comments
@mdtauk +1 For including a RadioButton OutlineStyle alone. |
Knew you'd like that. 😃 With the ghost style I was thinking of the ToggleMenuFlyoutItem and RadioMenuFlyout which enable selection, whilst not including the unselected visual. |
Thanks for the writing up the proposal! My only concern is with the ghost variants of the radiobutton and checkbox: removing the borders are a pretty big usability flaw IMO. I think those need to stay because the controls are now pretty much unrecognizable. |
I did place a dot where the mark should be, but it is also possible that there is another way to handle the indicators there, or just not have the ghost style apply to them. |
I'd go for the latter, so that the controls are still recognizable as a CheckBox/RadioButton. |
Maybe these designs are subtle enough to be considered ghost or stealthy. 20% Opacity for the borders at rest 60% opacity for the marks inside |
Using the colors in your screenshot, on a white background, you are unfortunately not meeting common contrast ratios such as WCAG AA for controls (20%) and for normal text(20%,40%). I am not sure if that is fine, but I would tend to, it's not enough contrast. The problem is that contrast and "stealthiness" are opposing each others, so it's a very difficult decision to make here. |
@chingucoding is correct. Many of the controls do look like they are not meeting contrast requirements and it is something we need to ensure. |
It is only the Ghost radio and checkboxes that are not meeting the requirement I think. The Outlined ones are based on the TextBoxes, so 40% border and 40% fill. The Filled controls are based on the button, so a 20% fill. |
Some accent button style API samples: Determining foreground: Button style: |
Proposal: Form Control Styles - Consistent to Fluent UI and FastDNA
Summary
As requested by @chigy this is a proposal to introduce some kind of FormControlStyle property to relevant controls, which enables the developer to set the visual look of their Form Controls from a set of known and approved designs which align to Fluent UI and FastDNA concepts of button types - without manually overriding or setting Xaml Styles - which would lead to inconsistent variations,
image is an example of how the controls would look in these initial 4 styles
Rationale
Scope
Important Notes
An initial thought would be some kind of enum which when set, will apply the alternative style to the control, and this could possibly be done at the App level, or inherited from a containing panel or page, as well as on an individual control. If that container panel also contains controls where this property does not apply, those controls should appear as normal.
Open Questions
The easier it is to set this style, the better it will be for developers who would rather not re-template controls just to make a slight change based on preferences - but this could also be done with ResourceDictionaries. If that approach is taken, then ensuring those can be created by Microsoft and distributed in some way, with plenty of exposure - is the only way I can think of to try to maintain consistency.
Also I am not sure about using the word Style in the property name, as it could be confusing with the existing Style property. So deciding on what these "alternatives" should be referred to would need to be decided on.
The idea is the key thing, the implementation is up to the community and the WinUI team.
Related Issues
The text was updated successfully, but these errors were encountered: