Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ProgressRing determinate mode animation feels slow (~3 s) when initial Value is set to 100 #3134

Closed
harvinders opened this issue Aug 15, 2020 · 9 comments
Labels
area-Progress ProgressBar, ProgressRing area-UIDesign UI Design, styling no-issue-activity team-Controls Issue for the Controls team

Comments

@harvinders
Copy link

Describe the bug

I have a ListView that display status of various items. One important thing the item display's is the download percentage. I am using the determinate ProgressRing to display the percentage.

One issue I noticed is that when the item view is displayed, the animation takes close to 3 seconds to animate to the 100% value. Which feels very slow. This is especially true, when the initial value is already 100%.

Also, because of virtualisation the item view is reused with different view models and hence every time a new viewmodel is used that has a 100% for download status, the control is animated again (taking ~3 seconds). This happens when you scroll up and down enough to trigger the virtualisation.

Expected behavior

The animation should probably take less than a second.

Also, for virtualisation scenario ideally there should be no animation. I can understand that is going to be not possible unless animation is completely disabled for 100% (value is already 100% when the control is loaded/displayed).

Screenshots

Version Info

NuGet package version:
2.5.0-prerelease.200812001

Windows app type:

UWP Win32
Yes
Windows 10 version Saw the problem?
Insider Build (xxxxx)
May 2020 Update (19041)
November 2019 Update (18363) Yes
May 2019 Update (18362)
October 2018 Update (17763)
April 2018 Update (17134)
Fall Creators Update (16299)
Creators Update (15063)
Device form factor Saw the problem?
Desktop Yes
Xbox
Surface Hub
IoT

Additional context

@msft-github-bot msft-github-bot added the needs-triage Issue needs to be triaged by the area owners label Aug 15, 2020
@StephenLPeters StephenLPeters added area-Progress ProgressBar, ProgressRing area-UIDesign UI Design, styling team-Controls Issue for the Controls team and removed needs-triage Issue needs to be triaged by the area owners labels Aug 17, 2020
@StephenLPeters
Copy link
Contributor

Would it be possible to include Gif's of the animation in question?

@harvinders
Copy link
Author

@StephenLPeters Give me a day or so, I need a tool record it. Gaming bar is disabled for me.

@StephenLPeters
Copy link
Contributor

PowerPoint has a good screen recording option if that is available to you.

@harvinders
Copy link
Author

@StephenLPeters
The one drive video link is https://1drv.ms/v/s!AjCjW_y_qIQIga88B8RNM1f1r4Dsbg?e=L9IJPH

Many of the items have the download status of 100%. Notice when I first load the items. The progress ring takes time to reach 100%. I think the animation should not take that long.

Also at the very end of the video, when I scroll down and scroll up again I suspect the virtualisation kicks in and the progress ring again takes time to show the status of 100%.

@StephenLPeters
Copy link
Contributor

Thanks, very helpful!

@robloo
Copy link
Contributor

robloo commented Aug 21, 2020

Really have a bad gut feeling about Lottie in places like this :)

@mdtauk
Copy link
Contributor

mdtauk commented Aug 22, 2020

As I mentioned in another repo - if this does not currently exist, then the ability to play animations in reverse, as well as with faster and slower speeds.

@AzAgarampur
Copy link

Question: Why did we move away from the spinning dots? Almost every progress ring uses that, even the Windows bootloader.

@github-actions
Copy link

This issue is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Aug 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Progress ProgressBar, ProgressRing area-UIDesign UI Design, styling no-issue-activity team-Controls Issue for the Controls team
Projects
None yet
Development

No branches or pull requests

6 participants