Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NavigationView: Remove logic checking for WUX NavigationViewItems (WinUI 3) #3236

Closed
Felix-Dev opened this issue Sep 3, 2020 · 1 comment
Closed

NavigationView: Remove logic checking for WUX NavigationViewItems (WinUI 3) #3236

Felix-Dev opened this issue Sep 3, 2020 · 1 comment
Labels
area-DevInternal Internal build infrastructure, code cleanup, engineering efficiency area-NavigationView NavView control no-issue-activity product-winui3 WinUI 3 issues team-Controls Issue for the Controls team

Comments

@Felix-Dev
Copy link
Contributor

With PR #3232 we are adding back logic to throw an exception when WUX NavigationViewItems are added to a MUX NavigationView. This logic is only needed for WinUI 2 and is not necessary for WinUI 3 and thus should be removed from the WinUI 3 code base.

@StephenLPeters FYI.
@msft-github-bot msft-github-bot added the needs-triage Issue needs to be triaged by the area owners label Sep 3, 2020
@Felix-Dev Felix-Dev mentioned this issue Sep 3, 2020
Merged
@StephenLPeters StephenLPeters added area-NavigationView NavView control team-Controls Issue for the Controls team area-DevInternal Internal build infrastructure, code cleanup, engineering efficiency product-winui3 WinUI 3 issues and removed needs-triage Issue needs to be triaged by the area owners labels Sep 3, 2020
@github-actions
Copy link

This issue is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-DevInternal Internal build infrastructure, code cleanup, engineering efficiency area-NavigationView NavView control no-issue-activity product-winui3 WinUI 3 issues team-Controls Issue for the Controls team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Felix-Dev @StephenLPeters @msft-github-bot