Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ProgressRing does not jump backward to a lower value when progress decreases #3562

Closed
MarissaMatt opened this issue Nov 5, 2020 · 6 comments · Fixed by #3565
Closed

ProgressRing does not jump backward to a lower value when progress decreases #3562

MarissaMatt opened this issue Nov 5, 2020 · 6 comments · Fixed by #3565
Labels
area-Progress ProgressBar, ProgressRing duplicate This issue or pull request already exists needs-author-feedback Asked author to supply more information. team-Controls Issue for the Controls team

Comments

@MarissaMatt
Copy link
Contributor

Describe the bug
When the ProgressRing needs to reduce the amount of progress made, the ring does not move backwards it only moves forwards.

Steps to reproduce the bug

Steps to reproduce the behavior:

  1. Set ProgressRing to a value of 60.
  2. Set the value to 50.
  3. ProgressRing completely fills in and animates forward to the value of 50.

Expected behavior
ProgressRing will jump back to the value of 50.

Version Info
WinUI 2.5

NuGet package version:
Microsoft.UI.Xaml v2.5.0-prerelease.201027002

@ghost ghost added the needs-triage Issue needs to be triaged by the area owners label Nov 5, 2020
@marcelwgn
Copy link
Contributor

I think this is a duplicate of #3173, @MarissaMatt can you confirm?

@MarissaMatt
Copy link
Contributor Author

You're correct! @ranjeshj could we assign someone to the issue that @chingucoding mentioned above? I'll close this one after the other bug is assigned. Good catch @chingucoding!

@StephenLPeters StephenLPeters added area-Progress ProgressBar, ProgressRing duplicate This issue or pull request already exists team-Controls Issue for the Controls team and removed needs-triage Issue needs to be triaged by the area owners labels Nov 6, 2020
@StephenLPeters
Copy link
Contributor

@chingucoding I saw you said you would like to look into the duplicate issue. Did you run into an issue with AVP that prevented the negative playback rate from working?

@StephenLPeters StephenLPeters added the needs-author-feedback Asked author to supply more information. label Nov 6, 2020
@marcelwgn
Copy link
Contributor

marcelwgn commented Nov 6, 2020

@StephenLPeters The issue is that the animation does in fact not play in reverse. When setting the playback rate to -1, instead of animating to that value, the progressring immediately jumped to that value. It would probably require some digging into the animation to figure out why a negative playback rate does not work as expected.

Edit: Created a PR to fix the behavior as best as we/I can. Animating backwards doesn't work, it jumps to the value, however that is far better than the current behavior.

@ranjeshj
Copy link
Contributor

ranjeshj commented Nov 6, 2020

@StephenLPeters The issue is that the animation does in fact not play in reverse. When setting the playback rate to -1, instead of animating to that value, the progressring immediately jumped to that value. It would probably require some digging into the animation to figure out why a negative playback rate does not work as expected.

Edit: Created a PR to fix the behavior as best as we/I can. Animating backwards doesn't work, it jumps to the value, however that is far better than the current behavior.

Jump when going backwards is what the spec calls for.

@marcelwgn
Copy link
Contributor

Jump when going backwards is what the spec calls for.

Oh I did not know that. In that case, I updated the PR description to close both this and #3173, I am sorry about the confusion and delay caused.

@ghost ghost removed the working on it label Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Progress ProgressBar, ProgressRing duplicate This issue or pull request already exists needs-author-feedback Asked author to supply more information. team-Controls Issue for the Controls team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants