Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expander Header Stretch is not Exposed #4248

Closed
michael-hawker opened this issue Feb 18, 2021 · 2 comments · Fixed by #4394
Closed

Expander Header Stretch is not Exposed #4248

michael-hawker opened this issue Feb 18, 2021 · 2 comments · Fixed by #4394
Labels
area-Expander help wanted Issue ideal for external contributors team-Controls Issue for the Controls team
Milestone
WinUI 2.6

Comments

@michael-hawker
Copy link
Collaborator

Describe the bug
This bug was inherited from the Toolkit style, see our issue describing the problem here: CommunityToolkit/WindowsCommunityToolkit#3070 This should be resolved before Expander ships stable.

We found in general that having the ToggleButton within the Expander control made re-styling the control very difficult for our developers. I had missed this on the original PR, I would have suggested exploring an alternative approach...

Expected behavior
Able to stretch the content of an Expander's Header

Additional context
Also there's a duplicate of ExpanderHeaderUpStyle both in the Theme Resources and the main Style for Expander.
@ghost ghost added the needs-triage Issue needs to be triaged by the area owners label Feb 18, 2021
@michael-hawker michael-hawker mentioned this issue Feb 18, 2021
Closed
7 tasks
@StephenLPeters StephenLPeters added area-Expander team-Controls Issue for the Controls team and removed needs-triage Issue needs to be triaged by the area owners labels Feb 19, 2021
@StephenLPeters
Copy link
Contributor

@ranjeshj FYI

@ranjeshj ranjeshj added this to the WinUI 2.6 milestone Feb 19, 2021
@ranjeshj ranjeshj added the help wanted Issue ideal for external contributors label Feb 19, 2021
@michael-hawker michael-hawker mentioned this issue Mar 1, 2021
Closed
@michael-hawker
Copy link
Collaborator Author

🦙 Also see #4391 and #4390 which should be resolved before shipping stable as well.

@robloo robloo mentioned this issue Mar 2, 2021
Merged
@ghost ghost added the working on it label Mar 2, 2021
@ghost ghost removed the working on it label Mar 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-Expander help wanted Issue ideal for external contributors team-Controls Issue for the Controls team
Projects
None yet
Milestone
WinUI 2.6
Development

Successfully merging a pull request may close this issue.

Expander Fixes
3 participants
@StephenLPeters @michael-hawker @ranjeshj