Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WinUI 2.6.1 AutoSuggestBox Search Icon Position Offset #5537

Closed
myokeeh opened this issue Jul 22, 2021 · 14 comments · Fixed by #5779
Closed

WinUI 2.6.1 AutoSuggestBox Search Icon Position Offset #5537

myokeeh opened this issue Jul 22, 2021 · 14 comments · Fixed by #5779
Labels
area-AutoSuggestBox help wanted Issue ideal for external contributors team-Controls Issue for the Controls team

Comments

@myokeeh
Copy link

myokeeh commented Jul 22, 2021

Describe the bug
The search icon on the AutoSuggestBox seems offset too far to the left or not right-justified.

Steps to reproduce the bug
Seems to be the default with no steps needed to reproduce.

Expected behavior
The icon ought to be right justified like it was on WinUI 2.5. No overlapping with search text or placeholder text.

Screenshots
image

image

image

Version Info
2.6.1

NuGet package version:
[Microsoft.UI.Xaml 2.6.1]

Windows app type:

UWP Win32
Yes
Windows 10 version Saw the problem?
Insider Build (21H2) Yes
October 2020 Update (19042)
May 2020 Update (19041)
November 2019 Update (18363)
May 2019 Update (18362)
October 2018 Update (17763)
April 2018 Update (17134)
Fall Creators Update (16299)
Creators Update (15063)
Device form factor Saw the problem?
Desktop Yes
Xbox
Surface Hub
IoT

Additional context
@ghost ghost added the needs-triage Issue needs to be triaged by the area owners label Jul 22, 2021
@StephenLPeters StephenLPeters added area-AutoSuggestBox help wanted Issue ideal for external contributors needs-cherrypicktorelease PR tagged for cherry-pick to the current release branch (but not yet picked) team-Controls Issue for the Controls team and removed needs-triage Issue needs to be triaged by the area owners labels Jul 22, 2021
@StephenLPeters StephenLPeters added this to the WinUI 2.7 milestone Jul 22, 2021
@StephenLPeters
Copy link
Contributor

Thanks! @ranjeshj 2.6?

@ranjeshj
Copy link
Contributor

ranjeshj commented Aug 4, 2021

@myokeeh I don't see this in XCG. Perhaps this is already resolved ? If not, can you provide repro steps ?

@ranjeshj ranjeshj removed the needs-cherrypicktorelease PR tagged for cherry-pick to the current release branch (but not yet picked) label Aug 4, 2021
@ranjeshj ranjeshj removed this from the WinUI 2.7 milestone Aug 4, 2021
@myokeeh
Copy link
Author

myokeeh commented Aug 5, 2021

@ranjeshj I don't know what XCG is.

image

@StephenLPeters
Copy link
Contributor

XamlControlsGallery

@myokeeh
Copy link
Author

myokeeh commented Aug 5, 2021

@ranjeshj @StephenLPeters here's a solution that reproduces this.
DELETE9.zip

@myokeeh
Copy link
Author

myokeeh commented Aug 17, 2021

@ranjeshj @StephenLPeters does it reproduce for you with this solution?

@marcelwgn
Copy link
Contributor

Thank you @myokeeh , I can repro it using your app. I'll look into this issue and see what could cause this.

@marcelwgn marcelwgn mentioned this issue Aug 26, 2021
Merged
@ghost ghost added the working on it label Aug 26, 2021
@niels9001 niels9001 mentioned this issue Sep 6, 2021
Closed
@ghost ghost removed the working on it label Oct 29, 2021
@myokeeh
Copy link
Author

myokeeh commented Dec 5, 2021

When do we expect this fix on 2.7.X?

@ghost ghost added the needs-triage Issue needs to be triaged by the area owners label Dec 5, 2021
@htcfreek
Copy link

Any updates when this fix will be released in 2.7 versions?

@ghost
Copy link

ghost commented Jan 19, 2022

🎉This issue was addressed in #5779, which has now been successfully released as Microsoft.UI.Xaml vMicrosoft.Experimental.UI.Xaml.2.8.0-prerelease.220118001.:tada:

Handy links:

@StephenLPeters StephenLPeters removed the needs-triage Issue needs to be triaged by the area owners label Feb 16, 2022
@StephenLPeters StephenLPeters mentioned this issue Mar 1, 2022
Closed
2 tasks
@ghost
Copy link

ghost commented Apr 14, 2022

🎉This issue was addressed in #5779, which has now been successfully released as Microsoft.UI.Xaml v2.8.0-prerelease.220413001.:tada:

Handy links:

@ghost
Copy link

ghost commented Jul 13, 2022

🎉This issue was addressed in #5779, which has now been successfully released as Microsoft.UI.Xaml v2.8.0-prerelease.220712001.:tada:

Handy links:

@ghost
Copy link

ghost commented Jul 18, 2022

🎉This issue was addressed in #5779, which has now been successfully released as Microsoft.UI.Xaml v2.8.0.:tada:

Handy links:

@myokeeh myokeeh mentioned this issue Aug 13, 2022
Closed
@ghost
Copy link

ghost commented Jan 3, 2023

🎉This issue was addressed in #5779, which has now been successfully released as Microsoft.UI.Xaml v2.8.2.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-AutoSuggestBox help wanted Issue ideal for external contributors team-Controls Issue for the Controls team
Projects
None yet
Milestone
No milestone
5 participants
@myokeeh @StephenLPeters @marcelwgn @ranjeshj @htcfreek