-
Notifications
You must be signed in to change notification settings - Fork 678
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal: SettingsCard, SettingsExpander, SettingsButton, SettingsGroup #8146
Comments
@onein528 To give you a bit of perspective on why we didn't include the SettingsGroup in the current Toolkit Labs SettingsControls: we want to make sure these controls can be as flexible and usable across as many scenarios as possible. A layout is maybe more of a design pattern vs. a control? In our samples we have created a Settingspage experience that is inline with the design specifications in case developers want to replicate this experience: https://github.com/CommunityToolkit/Labs-Windows/blob/main/labs/SettingsControls/samples/SettingsControls.Samples/SettingsPageExample.xaml As you can see, you can use the #82 might be a great way to create these layouts! |
I wonder why those controls aren’t here. |
I support this idea. Currently, C++ devs cannot use the settings control from the WCT. It should also be added to WinUI 2, because otherwise it leaves C++ UWP devs in a state where they will never get this important control for modern Windows 11 app design (while C# UWP devs have it from the WCT) |
Which of the various implementations are you basing yours on? Windows Terminal has something called the SettingsContainer |
@onein528 Maybe good to check with the maintenaing team first to see if they would be open for such PR :)?
@mdtauk The implementation that we've done in the Toolkit was together with the design team and is inline with the W11 Settings implementation (inc. a11y and resizing behavior). So I'd follow that as much as possible! |
@mdtauk Toolkit lab. They created with the design team(so I don't know if I can create the PR of this proposal😅) |
Proposal: SettingsCard, SettingsExpander, SettingsButton, SettingsGroup
The new Windows 11 Settings app experience has gained a lot of approval and is used as the standard for many apps.
However, the implementation of each app is very different and the lack of these standard controls has frustrated developers having to create them again and again.
Toolkit Lab has already created some of those controls as a sample but it is not full control and so I decided to bring this conversation into here WinUI.
Summary
Naming validation
SettingsControls
is valid naming because these controls are only used in settings pages or apps.FormControls
#82 was valid for Windows 10 Settings control styles.Rationale
Scope
Important Notes
SettingsCard
Default
SettingsExpander
Expanded
Collapsed
Expanded, multiple SettingsExpanderItemCard, Footer
Expanded, multiple SettingsExpanderItemButton
SettingsButtons
Default
SettingsGroup
Default
Open Questions
Create SettingsCard with 'IsClickable' property and Remove SettingsButtonName validation: Settings* or Form*References
The text was updated successfully, but these errors were encountered: