Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PaneFooter NavigationViewItem causing crash in SDK 1.5 #9396

Closed
p2pbsh opened this issue Mar 4, 2024 · 3 comments
Closed

PaneFooter NavigationViewItem causing crash in SDK 1.5 #9396

p2pbsh opened this issue Mar 4, 2024 · 3 comments
Labels
area-NavigationView NavView control bug Something isn't working closed-Fixed Described behavior has been fixed. Regression team-Controls Issue for the Controls team
Milestone

Comments

@p2pbsh
Copy link

p2pbsh commented Mar 4, 2024

Describe the bug

Clicking on an icon for a NavigationViewItem within the PaneFooter area now causes an invalid range xaml exception after updating to SDK 1.5.

Steps to reproduce the bug

  1. Issue can be observed on the WinUI 3 Gallery app, please see attached screen grab.
  2. WinUI 3 Gallery app now crashes, as also observed on my own app.

Expected behavior

No response

Screenshots

Screenshot 2024-03-04 205703

NuGet package version

WinUI 3 - Windows App SDK 1.5.0: 1.5.240227000

Windows version

Windows 10 (21H2): Build 19044

Additional context

No response

@p2pbsh p2pbsh added the bug Something isn't working label Mar 4, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the needs-triage Issue needs to be triaged by the area owners label Mar 4, 2024
Copy link

github-actions bot commented Mar 4, 2024

Hi I'm an AI powered bot that finds similar issues based off the issue title.

Please view the issues below to see if they solve your problem, and if the issue describes your problem please consider closing this one. Thank you!

Closed similar issues:

Note: You can give me feedback by thumbs upping or thumbs downing this comment.

@bpulliam bpulliam added area-NavigationView NavView control team-Controls Issue for the Controls team Regression and removed needs-triage Issue needs to be triaged by the area owners labels Mar 4, 2024
@jaimecbernardo
Copy link

We found this crash while trying to update WinAppSDK to 1.5 as well in PowerToys.

We currently have a workaround:
microsoft/PowerToys@6ca19a5

But would prefer if we could keep using a NavigationView.PaneFooter like before instead of NavigationView.FooterMenuItems, since NavigationView.FooterMenuItems will behave as a selectable part of the NavView, which we don't intend here:
image

("Welcome to PowerToys" is a button that opens another window. "Image Resizer" should've kept being selected even after we press "Welcome to PowerToys")

@p2pbsh
Copy link
Author

p2pbsh commented Mar 6, 2024

We currently have a workaround: [microsoft/PowerToys@6ca19a5]

Thanks for the workaround, will give that a go.

@llongley llongley added this to the WinAppSDK 1.6 milestone Mar 8, 2024
@llongley llongley closed this as completed Mar 8, 2024
@llongley llongley added the closed-Fixed Described behavior has been fixed. label Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-NavigationView NavView control bug Something isn't working closed-Fixed Described behavior has been fixed. Regression team-Controls Issue for the Controls team
Projects
None yet
Development

No branches or pull requests

5 participants