Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable in-app Toolbar in XAML Hot Reload crashes in App SDK 1.5 #9853

Open
JochemPalmsens opened this issue Jul 25, 2024 · 3 comments
Open
Labels
area-HotReload bug Something isn't working team-Reach Issue for the Reach team

Comments

@JochemPalmsens
Copy link

JochemPalmsens commented Jul 25, 2024

Describe the bug

This is a kind-of successor to #8806 I managed to get a situation where the application crashes when the XAML Hot Reload in-app toolbar is enabled, but now in WinAppSDK 1.5.240627000

Steps to reproduce the bug

I haven't pin-pointed it precisely, but it seems to happen when a new window (in our case containing a webview 2 element) is quickly opened and closed. (We use it for OAuth0 logout)

Expected behavior

Of course we expect the application not to crash. We have no issues when we disable the in-app toolbar

Screenshots

Exception:
image

Call stack:
image

NuGet package version

WinUI 3 - Windows App SDK 1.5.5: 1.5.240627000

Windows version

Windows 11 (22H2): Build 22621

Additional context

Visual Studio Professional 17.10.5

I would be glad to help debug this, but I don't know where to begin. The screenshot shows a null-reference exception

@JochemPalmsens JochemPalmsens added the bug Something isn't working label Jul 25, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the needs-triage Issue needs to be triaged by the area owners label Jul 25, 2024
Copy link

Hi I'm an AI powered bot that finds similar issues based off the issue title.

Please view the issues below to see if they solve your problem, and if the issue describes your problem please consider closing this one. Thank you!

Closed similar issues:

Note: You can give me feedback by thumbs upping or thumbs downing this comment.

@JochemPalmsens
Copy link
Author

I managed to get some disassebly info:
image

@JesseCol JesseCol added team-Reach Issue for the Reach team area-HotReload and removed needs-triage Issue needs to be triaged by the area owners labels Jul 29, 2024
@wbokkers
Copy link

wbokkers commented Sep 6, 2024

I see the same issue in App SDK 1.6 when closing a (child) Window.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-HotReload bug Something isn't working team-Reach Issue for the Reach team
Projects
None yet
Development

No branches or pull requests

3 participants