Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[email protected] #1211

Closed
mysticatea opened this issue Nov 25, 2018 · 4 comments
Closed

[email protected] #1211

mysticatea opened this issue Nov 25, 2018 · 4 comments

Comments

@mysticatea
Copy link

The package-lock.json includes [email protected] which includes malicious code: package-lock.json#L1090-L1095.

See also: dominictarr/event-stream#116

The event-stream package looks unsafe. It's better to find an alternative in my 2 cents.

@lmcarreiro
Copy link

After the mess, the dependency to flatmap-stream was removed and the event-stream is maintained by the NPM team now.

@alexdima
Copy link
Member

Thank you for the heads up. I have locked the dependency to [email protected] which gets rid of flatmap-stream from the dev dependencies.

@shivam183
Copy link

Hi, I'm new to MEAN stack and can anyone please tell me how to safely remove or update this dependency from package-lock.json using NPM

@KudMath
Copy link

KudMath commented Nov 29, 2018

@shivam183 here is how I did it : remove your package-lock.json, lock your dependency to event-stream at version 3.3.4 by adding "event-stream": "3.3.4", to your package.jsonrun npm i (that should work if your flatmap-stream dependency comes from event stream, if not you can repeat those steps for the respective 'ancestors')

@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants