Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] IStandaloneCodeEditor.onDidChangeConfiguration does not fire when tabFocusMode is changed #4740

Open
1 of 2 tasks
amv146 opened this issue Nov 5, 2024 · 0 comments
Open
1 of 2 tasks

Comments

@amv146
Copy link

amv146 commented Nov 5, 2024

Reproducible in vscode.dev or in VS Code Desktop?

  • Not reproducible in vscode.dev or VS Code Desktop

Reproducible in the monaco editor playground?

Monaco Editor Playground Link

https://microsoft.github.io/monaco-editor/playground.html?source=v0.52.0#XQAAAAKqAQAAAAAAAABBqQkHQ5NjdMjwa-jY7SIQ9S7DNlzs5W-mwj0fe1ZCDRFc9ws9XQE0SJE1jc2VKxhaLFIw9vEWSxW3yscwzzSoHfGetpg8d5BCIdogK6CBmgyKHIOVjH6uO-oA-RA-rcpQdGBlgwMT7NDeGjyzFr76MYz0c_YZhkfVact66KR8C292eYPotyrTpNzU4R2pnsg0qMoJFMwW0-anHTtAsGYd8vCeUpVswYFrP72raJqV9anqkd1j9jzqyU9LIcX7Tsw5ZHju14bgnXGT_1jFdi35F53qgwGQlYCxtuQo0E9RLxQwABNyr8p0Pk9P1BV_WsoxPSlyClyFxkPHtujBEuyUl7I-AMd-ICfjOGnF4hktGqtJD2U2lW4tZcb2_1CP5P34uuI9YAXpiZnr-04nkjRaUEVYGWGCySabpG-IJwPL_5BqO9SEQfiX-n7D0A

Monaco Editor Playground Code

const value = /* set from `myEditor.getModel()`: */ `function hello() {
	alert('Hello world!');
}`;

// Hover on each property to see its docs!
const myEditor = monaco.editor.create(document.getElementById("container"), {
	value,
	language: "javascript",
	automaticLayout: true,
});

myEditor.onDidChangeConfiguration((e) => {
    alert("Config changed!")
});

Reproduction Steps

  1. Add handler for onDidChangeConfiguration
  2. In Monaco Editor, click Ctrl + M to change tab focus mode
  3. Observe that an event is not raised for onDidChangeConfiguration, but the tab focus mode is changed in the editor

Actual (Problematic) Behavior

The handler for onDidChangeConfiguration is not called.

Expected Behavior

The handler for onDidChangeConfiguration should be called

Additional Context

This issue seems to have originated from 0.36.0. May be related to this bug:

#1493

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant