Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SqlServerDriver.acceptUrl works wrong #1188

Closed
Pryanic opened this issue Nov 22, 2019 · 5 comments · Fixed by #1251
Closed

SqlServerDriver.acceptUrl works wrong #1188

Pryanic opened this issue Nov 22, 2019 · 5 comments · Fixed by #1251

Comments

@Pryanic
Copy link

Pryanic commented Nov 22, 2019

Driver version

7.2.0.jre8
8.1.0.jre11-preview

SQL Server version

MsSql16

Client Operating System

MacOs

JAVA/JVM version

Java12

Table schema

My connection string looks like

jdbc:sqlserver://myIp:1433;database=master;password=pass**;**sdfsdf%;user=my_user;

As you see my password contains ;. I use Hikari CP and this pool uses acceptUrl method. I don't want change my password and I want to use Hikari CP. Can you help me with it?

@Pryanic Pryanic changed the title SqlServerDriver.acceptUrl works wornd SqlServerDriver.acceptUrl works wrong Nov 22, 2019
@ulvii
Copy link
Contributor

ulvii commented Nov 22, 2019

Hi @Pryanic ,
The behavior is not wrong, you need to escape semicolons, see Using SQL escape sequences. Try jdbc:sqlserver://myIp:1433;database=master;password={pass**;**sdfsdf%};user=my_user;.

@ulvii ulvii closed this as completed Nov 27, 2019
@Pryanic
Copy link
Author

Pryanic commented Dec 2, 2019

How I should handle such password pasS};word={qq?
@ulvii

@ulvii
Copy link
Contributor

ulvii commented Dec 4, 2019

pasS};word={qq should be escaped as {pasS}};word={qq}, but looks like driver does not handle this case. I will work on a PR for this scenario.

@Pryanic
Copy link
Author

Pryanic commented Jan 14, 2020

@ulvii Did you fix the bug?

@rene-ye
Copy link
Member

rene-ye commented Jan 16, 2020

We will fix this issue in a later release, it's in our backlog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants