Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Inbuilt function to extract nested JSON #798

Merged
merged 9 commits into from
Oct 21, 2024
Merged

Added Inbuilt function to extract nested JSON #798

merged 9 commits into from
Oct 21, 2024

Conversation

pioneerHitesh
Copy link
Contributor

@pioneerHitesh pioneerHitesh commented Sep 18, 2024 •
edited
Loading

Added Inbuilt function to extract nested JSON especially for AuditData Column. Closes #589.

@pioneerHitesh
Copy link
Contributor Author

@ianhelle could you please review this?

@pioneerHitesh
Copy link
Contributor Author

@ianhelle may you review this please?

@ianhelle
Fixing a pylint error in network_plot.py
4e9c793 
(this is due to an update to pylint, not the code in this PR)
@ianhelle
Copy link
Contributor

Looks good. I have approved and ran build checks.
Looks like you have a couple of minor issues from pylint and pydocstyle - I've highlighted these in the comments.
I've also pushed a fix in network_plot.py - unrelated to this PR. This was triggered by a new or updated check in pylint.

@pioneerHitesh
Copy link
Contributor Author

@ianhelle I have fixed the liniting issues except for errors caused by thebandit. May you please help me fixing the timeout issues which bandit is reporting?

ianhelle
ianhelle approved these changes Oct 20, 2024
View reviewed changes
msticpy/init/pivot_core/pivot_pd_accessor.py Show resolved Hide resolved
msticpy/init/pivot_core/pivot_pd_accessor.py Show resolved Hide resolved
msticpy/init/pivot_core/pivot_pd_accessor.py Outdated Show resolved Hide resolved
msticpy/init/pivot_core/pivot_pd_accessor.py Show resolved Hide resolved
msticpy/init/pivot_core/pivot_pd_accessor.py Outdated Show resolved Hide resolved
@ianhelle ianhelle merged commit 11ca944 into microsoft:main Oct 21, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ianhelle ianhelle ianhelle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inbuilt function to extract nested JSON in AuditData field in M365 UAL logs
2 participants
@pioneerHitesh @ianhelle