Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with timeseries analysis in the case of score > score_threshold & seasonal == 0 #615

Open
pensivepaddle opened this issue Jan 30, 2023 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@pensivepaddle
Copy link
Contributor

https://github.com/microsoft/msticpy/blob/main/msticpy/analysis/timeseries.py#L293-L299

Missing logic for time series anomaly detection for the case of
(result["score"] > score_threshold) & (result["seasonal"] == 0)

whereas >0 and <0 are covered.

It leads to an error in the later typecasting to int64.

Not sure if change from lt/gt to le/ge, or a different approach is most appropriate.

@ianhelle ianhelle added the bug Something isn't working label Jan 30, 2023
@ianhelle
Copy link
Contributor

@ashwin-patil - not sure what the correct thing to do here is. Seems like setting anomalies should default to 0 before the two statements that set to +/- 1.
Since there are 2 separate values being used here to determine anomaly marking, there are potential cases where score could be >, < and == score_threshold, also where seasonal could be >, < and == 0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants