v3.3.0 induce breaking changes in some packages of the ecosystem

[Zer0xxxx]

Hello!
I've noticed that some packages (for example: wireit) have been broken with the release of the v3.3.0 of jsonc-parser.

Related to: google/wireit#1111

[rijkvanzanten]

I've been seeing the same behavior starting 3.3.0. In my case it's through the use of rollup-plugin-esbuild, but the symptom and results are the same.

file:///{{REDACTED}}/node_modules/rollup-plugin-esbuild/dist/index.mjs:11
import { parse } from "jsonc-parser";
         ^^^^^
SyntaxError: Named export 'parse' not found. The requested module 'jsonc-parser' is a CommonJS module, which may not support all module.exports as named exports.

[jakebailey]

See also:

• Fix ESM exports #78 (comment)
• prepare 3.3.0 #90 (comment)

[aeschli]

Fix is on the way, I'll revert the change.

[jakebailey]

3.3.1 has brought things back to the way they were before:

• https://arethetypeswrong.github.io/?p=jsonc-parser%403.3.1
• https://publint.dev/[email protected]

[Zer0xxxx]

3.3.1 has brought things back to the way they were before:

* https://arethetypeswrong.github.io/?p=jsonc-parser%403.3.1

* https://publint.dev/[email protected]

Oh my god, this is AWESOME, thank you!
Can I remove the overrides in my package.json (using pnpm) and check for you if all works again as expected in my project?

[jakebailey]

Yes, just avoid 3.3.0.

[Zer0xxxx]

Yes, just avoid 3.3.0.

It's fine for me, using wireit, all works again as expected, thank you!

[Zer0xxxx]

Hello @jakebailey
Should we close this issue as resolved?

[jakebailey]

Sure (I'm not on the team that works on this package so I can't do it).

[Zer0xxxx]

Sure (I'm not on the team that works on this package so I can't do it).

Okay, let's close this!
Feel free to reopen this issue if you need to.