Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detecting :: as IPv6 Address #1395

Open
troy256 opened this issue Jun 4, 2024 · 5 comments
Open

Detecting :: as IPv6 Address #1395

troy256 opened this issue Jun 4, 2024 · 5 comments

Comments

@troy256
Copy link

troy256 commented Jun 4, 2024

Describe the bug
We are indirectly using this library as part of PII detection for text coming from a GenAI based coding assistant. However it is detecting every instance of "::" as PII, because IPv6 addresses can contain this. This string is regularly used in Perl, as well as C++ and PHP. E.g. -

use strict;
use warnings;
use LWP::UserAgent; <-- detected as PII

Expected behavior
Ideally the IPv6 detection would be smart enough to know the difference between programming language use vs an actual IPv6 address.

Additional context
Very similar to Issue #907

@SharonHart
Copy link
Contributor

SharonHart commented Jun 20, 2024

:: is a valid ipv6 address
The solution might be to split the regex into two and drop the score for ::
Anyone up for fixing it?

@troy256
Copy link
Author

troy256 commented Jun 20, 2024

Even though :: is a valid IPv6 address, it's not personally identifiable and is effectively anonymous. So maybe skip over it?

@omri374
Copy link
Contributor

omri374 commented Jun 20, 2024

A simple workaround would be to add :: as an allow_list term.

@troy256
Copy link
Author

troy256 commented Jun 26, 2024

Can that be done with configuration or is that a code change?

@omri374
Copy link
Contributor

omri374 commented Jun 27, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants