Feature request: Imports on a new line

[Ran4]

If we have this code, where the cursor it at |:

from uuid import (
    UUID,
)

uuid4|

and choose to auto-import uuid4 from uuid, then I end up with

from uuid import (
    UUID, uuid4,
)

uuid4|

Describe the solution you'd like

In order to generate more readable git diffs, I much prefer this behaviour:

from uuid import (
    UUID,
    uuid4,
)

uuid4|

It would be really cool if there was a way of customizing this behaviour.

[erictraut]

Thanks for the suggestion.

Since this isn't a core type checking feature and is instead a language server feature, I'm going to transfer it to the pylance repo where it will receive attention and discussion.

We tend to try to avoid adding new settings if we can help it. I think we could avoid making this configurable by adding more smarts to the auto-insert logic. If the import is already using a multi-line format, we should probably honor that.

[erictraut]

I've added a new heuristic so the auto-import text honors the existing formatting.

from uuid import UUID

becomes

from uuid import UUID, uuid4

and

from uuid import (
    UUID,
)

becomes

from uuid import (
    UUID,
    uuid4,
)

This avoids the need for an explicit setting.

This change will be in the next release of pylance.

[jakebailey]

This issue has been fixed in version 2021.3.4, which we've just released. You can find the changelog here: https://github.com/microsoft/pylance-release/blob/main/CHANGELOG.md#202134-31-march-2021