Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression of issue #471 #1132

Closed
onet-git opened this issue Apr 6, 2021 · 2 comments
Closed

Regression of issue #471 #1132

onet-git opened this issue Apr 6, 2021 · 2 comments
Labels
bug Something isn't working fixed in next version (main) A fix has been implemented and will appear in an upcoming version

Comments

@onet-git
Copy link

onet-git commented Apr 6, 2021

Environment data
Language Server version: 2021.3.4
OS and version: Ubuntu Bionic
Python version (& distribution if applicable, e.g. Anaconda): 3.6

The exact same thing as failed in #471 is failing again. Same test setup fails in the same was as before. The console log shows that it doesn't even look at the "python.analysis.extraPaths" once it finds a file within a matching module directory.

I suspect this is due to recent performance improvements, as that was the reason for the original issue.

@github-actions github-actions bot added the triage label Apr 6, 2021
@erictraut
Copy link
Contributor

Thanks for reporting this (again). It turns out that the original fix was incomplete and happened to work because of the order in which we were enumerating directories. That changed recently when we added symlink support, so it exposed this bug.

I've fixed the original bug and added more robust unit tests to cover this case so we don't introduce another regression in the future.

@erictraut erictraut added bug Something isn't working fixed in next version (main) A fix has been implemented and will appear in an upcoming version and removed triage labels Apr 6, 2021
@jakebailey
Copy link
Member

This issue has been fixed in version 2021.4.0, which we've just released. You can find the changelog here: https://github.com/microsoft/pylance-release/blob/main/CHANGELOG.md#202140-7-april-2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fixed in next version (main) A fix has been implemented and will appear in an upcoming version
Projects
None yet
Development

No branches or pull requests

3 participants