New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

staticmethod builtin wrapper hides function signatures #1210

Closed

bschnurr opened this issue Apr 29, 2021 · 2 comments

Assignees

Labels

needs investigation

Member

bschnurr commented Apr 29, 2021

Environment data

Language Server version: XXX
OS and version: XXX
Python version (& distribution if applicable, e.g. Anaconda): XXX

Expected behaviour

correct function signature
to_wei(number: Union[int, float, str, decimal.Decimal], unit: str) -> int:

Actual behaviour

Logs

XXX

Code Snippet / Additional information

from web3 import Web3

Web3.toWei(1, 'ether')

The text was updated successfully, but these errors were encountered:

github-actions bot added the triage label

Member Author

bschnurr commented Apr 29, 2021

this could be more related to the way they are using staticmethod.. i haven't seen it used like this in any other examples. the usage i've see is staticmethod(classname.methodname) or as a fixture.

bschnurr added the needs investigation label

github-actions bot removed the triage label

heejaechang self-assigned this

bschnurr mentioned this issue

converting staticmethod calls to the proper decorator usage. ethereum/web3.py#1979

Merged

1 task

Contributor

savannahostrowski commented Jun 9, 2021

Fixed upstream ethereum/web3.py#1979

savannahostrowski closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment