Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing docstings for stdlib decimal module #1350

Closed
arian47 opened this issue May 26, 2021 · 3 comments
Closed

Missing docstings for stdlib decimal module #1350

arian47 opened this issue May 26, 2021 · 3 comments
Labels
enhancement New feature or request fixed in next version (main) A fix has been implemented and will appear in an upcoming version

Comments

@arian47
Copy link

arian47 commented May 26, 2021

Environment data

  • Language Server version: 2021.5.4-pre.1
  • OS and version: ubuntu 21.04
  • Python version: 3.9.4 64-bit

Expected behaviour

pylance showing the docstring of the builtin decimal module's functions

Actual behaviour

not showing docstrings which are available in the pythons website in the documentation section about the library

Code Snippet / Additional information

from decimal import Decimal
Decimal(3.14).min()
Screenshot from 2021-05-26 22-59-45
Screenshot from 2021-05-26 22-58-01

@jakebailey
Copy link
Member

This is a unique case, as decimal is stubbed in typeshed differently than exists in the real code. The real code forwards to the _decimal or _pydecimal modules, but there's no stub for that. We try and extract info from decimal.py but find nothing.

@judej judej added enhancement New feature or request needs investigation Could be an issue - needs investigation labels May 27, 2021
@github-actions github-actions bot removed the triage label May 27, 2021
@jakebailey jakebailey changed the title pylance not showing docstrings for the builtin decimal module's functions Missing docstings for stdlib decimal module Aug 30, 2021
@jakebailey jakebailey added the fixed in next version (main) A fix has been implemented and will appear in an upcoming version label Aug 31, 2021
@jakebailey
Copy link
Member

The next version of Pylance should support decimal's docstrings.

@jakebailey jakebailey removed the needs investigation Could be an issue - needs investigation label Sep 1, 2021
@jakebailey
Copy link
Member

This issue has been fixed in version 2021.7.0, which we've just released. You can find the changelog here: https://github.com/microsoft/pylance-release/blob/main/CHANGELOG.md#202190-1-september-2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request fixed in next version (main) A fix has been implemented and will appear in an upcoming version
Projects
None yet
Development

No branches or pull requests

4 participants