Many spurious warnings after running unit test #1404
Labels
waiting for user response
Requires more information from user
Comments
|
Could you please verify that the diagnostics are being logged by Pylance rather than some other extension? I can't tell for sure from the screen shot above. If you click on the triangle on the left, the individual problems will be displayed for a file. If they're coming from Pylance, you'll see "Pylance [x, y]" in gray at the end of the message. |
|
The messages are all from pylance. At some point I was debugging with "Raised Exceptions" on, so it might have opened a file in my environment, but in any case the behavior became "sticky" after that. I will paste some diagnostics as soon as I'm able to reproduce the behavior that vanished after restarting with logs enabled... |
|
Thanks. Yes, trace logs would be really helpful. So would any repro steps you discover. |
|
Ok, this is what I got. At the point I copied the log there was a genericpath.py warning, but when I was about to take the screenshot it dissappeared (these spurious reports seem to come and go in a while). It clearly is something with being debugging, maybe in combination with testing, but now I have disabled breakpoints on raised exceptions and it's still happening. |
|
That's the python output panel, doesn't seem very useful, do you want the one for the language server? I don't see one output dedicated to pylance. |
|
Yeah, we need the logs for the "Python Language Server". (We should maybe rename that to "Pylance" so it's more obvious. @jakebailey.) |
|
Ok, I was not sure whether pylance was the static analyzer or the language server. |
|
Here is another one:
|
|
One thing that I noticed here is that you appear to have a Python 2.7 interpreter selected. Pylance does not support Python 2.7. It will do its best, but you will likely run into various issues. If you still need to use Python 2.7, I recommend choosing a different language server like Jedi. That said, I don't think this explains the behavior you're seeing here, so we should continue to investigate this issue. |
|
Ok, thanks. It's just this project that is in python 2, switching back to jedi for it. I will check again later if I can reproduce the same issue in python 3. |
|
I can confirm this is also happening running tests in python 3, even without using the debugger:
|
|
Are you on the latest 2021.6.1 version we released yesterday, by chance? We included a fix there intended to help fix casing issues in paths, and I'm wondering if this is related. |
|
Almost there, not yet :) |
|
Is there any way we could get an LSP trace from you, end to end showing what happens? To do this, you would set the undocumented setting To confirm, you don't see this, then do something with unit testing in the Python extension, then they appear? I believe that the Python extension calls us for symbols, so it could be that we are misinterpreting these files as "opened" and showing diagnostics for them. (The code that calls us is slated to be removed pretty soon, though, so this may resolve itself in time.) |
|
This might have been fixed in microsoft/pyright@d01295d (which will be in today's release). |
|
I'm going to close this with the assumption that the above is true, but if this comes back we're happy to reopen. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I've original commented this in:
#422 (comment)
but I'm opening a new issue because this seems triggered by unit testing.
Environment data
Actual behaviour
This is not an isolated occurrence, it happens very often.
Expected behaviour
Since:
I expect not to get tons of warnings about files I don't care about, because the abundance of false positives renders the help of the linter almost useless.
Logs
I'm having a hard time trying to systematically reproduce this, so traces are getting too long to be pasted.
Code Snippet / Additional information
XXXThe text was updated successfully, but these errors were encountered: