Rename Symbol skips unreachable code

[xavdid]

Environment data

• Language Server version: 2022.2.1
• OS and version: darwin arm64
• Python version (and distribution if applicable, e.g. Anaconda):
• python.analysis.indexing: null
• python.analysis.typeCheckingMode: basic

Expected behaviour

All references to the same symbol are renamed, even those that are otherwise unreachable.

Actual behaviour

Unreachable symbols aren't renamed. If the line causing code to be unreachable is removed after rename, then you have undefined variables caused by the renamer.

Apologies in advance if this is working as intended, it just seemed like odd behavior to me.

Logs

Python Language Server Log

(there was no data on my clipboard); manually fetched logs didn't seem relevant. Happy to include them if needed.

Code Snippet / Additional information

Renaming a -> b doesn't rename unreachable symbol

def f():
    a = 1
    a += 2
    return a

    a += 4 # isn't renamed

[erictraut]

Thanks for the bug report. This will be fixed in the next release.

[bschnurr]

This issue has been fixed in version 2022.3.1, which we've just released. You can find the changelog here: CHANGELOG.md