Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vscode.dev - 'Pylance: Report Issue...' command shows error #2791

Closed
egamma opened this issue May 10, 2022 · 6 comments
Closed

vscode.dev - 'Pylance: Report Issue...' command shows error #2791

egamma opened this issue May 10, 2022 · 6 comments
Assignees
Labels
bug Something isn't working fixed in next version (main) A fix has been implemented and will appear in an upcoming version

Comments

@egamma
Copy link
Member

egamma commented May 10, 2022

I ran into an issue (#19107) with the python extension using vscode.dev and tried to report the issue following the instructions https://github.com/microsoft/vscode-python/wiki/Reporting-a-bug.

@brettcannon the page mentions to use Python: Report Issue... which is not available in vscode.dev. Therefore I've tried Pylance: Report Issue... .

To reproduce

The following error shows up:
image

@karthiknadig
Copy link
Member

@egamma For the web we provide a link see here: https://github.com/microsoft/vscode-python/wiki/Reporting-a-bug#web

@karthiknadig karthiknadig transferred this issue from microsoft/vscode-python May 10, 2022
@judej judej added needs investigation Could be an issue - needs investigation and removed triage labels May 10, 2022
@egamma
Copy link
Member Author

egamma commented May 11, 2022

@karthiknadig

@egamma For the web we provide a link see here: https://github.com/microsoft/vscode-python/wiki/Reporting-a-bug#web

sry I've overlooked that. I suggest to include this link inline in the little program on top of the reporting a bug wiki page
image

Obviously the command Pylance: Report Issue... should still not fail in vscode.dev/github.dev 😄 .

@brettcannon
Copy link
Member

Updated the wiki page to inline the link.

@debonte
Copy link
Contributor

debonte commented May 18, 2022

@luabud it turns out that this isn't a browser-specific issue. It works fine in both browser and desktop if the vscode-pylance extension has activated, but fails in both if it has not.

@debonte
Copy link
Contributor

debonte commented May 18, 2022

I think I found the answer on https://code.visualstudio.com/api/extension-guides/command#creating-a-user-facing-command:

We still need to call registerCommand to actually tie the command ID to the handler. This means that if the user selects the myExtension.sayHello command from the Command Palette but our extension has not been activated yet, nothing will happen. To prevent this, extensions must register an onCommand activationEvent for all user facing commands:

{
"activationEvents": ["onCommand:myExtension.sayHello"]
}

Now when a user first invokes the myExtension.sayHello command from the Command Palette or through a keybinding, the extension will be activated and registerCommand will bind myExtension.sayHello to the proper handler.

@debonte debonte assigned debonte and unassigned bschnurr May 20, 2022
@debonte debonte added bug Something isn't working and removed needs investigation Could be an issue - needs investigation labels May 23, 2022
@debonte debonte closed this as completed May 23, 2022
@debonte debonte added the fixed in next version (main) A fix has been implemented and will appear in an upcoming version label May 23, 2022
@debonte debonte reopened this May 23, 2022
@debonte
Copy link
Contributor

debonte commented May 25, 2022

This issue has been fixed in version 2022.5.3, which we've just released. You can find the changelog here: CHANGELOG.md

@debonte debonte closed this as completed May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fixed in next version (main) A fix has been implemented and will appear in an upcoming version
Projects
None yet
Development

No branches or pull requests

6 participants