Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Imports consumed in later cells flagged as unused with LSP notebooks #2986

Closed
debonte opened this issue Jul 1, 2022 · 2 comments
Closed
Assignees
Labels
fixed in next version (main) A fix has been implemented and will appear in an upcoming version

Comments

@debonte
Copy link
Contributor

debonte commented Jul 1, 2022

This was reported via a Marketplace review:

When I use Jupyter notebook and put the imported modules in a separate cell, Pylance always shows "module not used/module not accessed" despite the fact that they are used in the cells below. The bug needs to be fixed. (Then I installed old version v2022.5.1, there is no such problem)

This repros when the LSP notebooks experiment is enabled (but not with concat docs) because we aren't checking to see if symbols imported in a cell are used in later cells.

@debonte debonte self-assigned this Jul 1, 2022
@debonte debonte added the fixed in next version (main) A fix has been implemented and will appear in an upcoming version label Jul 5, 2022
@debonte
Copy link
Contributor Author

debonte commented Jul 5, 2022

These features will be disabled for LSP notebooks in the next release. We don't see any good ways to support these features when LSP notebooks are in use.

@heejaechang
Copy link
Contributor

This issue has been fixed in version 2022.7.21, which we've just released. You can find the changelog here: CHANGELOG.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixed in next version (main) A fix has been implemented and will appear in an upcoming version
Projects
None yet
Development

No branches or pull requests

2 participants