-
Notifications
You must be signed in to change notification settings - Fork 767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore Patterns option does not disable type checking. #3261
Comments
@MinekPo1 Can you elaborate on what the ignore patterns are? |
@karthiknadig sorry for not specifying in the original issue, as it seemed obvious to me. I am referring to the The way I usually access the setting is by searching for |
@MinekPo1 Can you share what you have set or is it just default? |
@karthiknadig default + point 2 of steps to reproduce (added |
This should be handled in |
related to #3266 |
This issue has been fixed in prerelease version 2022.9.11, which we've just released. You can find the changelog here: CHANGELOG.md |
Issue Type: Bug
Behaviour
Expected vs. Actual
Expected: Issues from ignored files found by static type checkers and other linters are ignored.
Actual: Issues found by type checkers are still shown
Steps to reproduce:
hidden.py
:Add
hidden.py
to ignored patternsObserve the pep8 violations disappear, but the static type checker errors remain.
Before adding to ignored patterns:
After:
Diagnostic data
python.languageServer
setting: PylanceUser Settings
Extension version: 2022.4.1
VS Code version: Code 1.66.0 (e18005f0f1b33c29e81d732535d8c0e47cafb0b5, 2022-03-30T05:50:14.623Z)
OS version: Windows_NT x64 10.0.19044
Restricted Mode: No
System Info
canvas_oop_rasterization: disabled_off
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
multiple_raster_threads: enabled_on
oop_rasterization: enabled
opengl: enabled_on
rasterization: enabled
raw_draw: disabled_off_ok
skia_renderer: enabled_on
video_decode: enabled
video_encode: enabled
vulkan: disabled_off
webgl: enabled
webgl2: enabled
A/B Experiments
The text was updated successfully, but these errors were encountered: