Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate Results #3530

Closed
byehack opened this issue Oct 25, 2022 · 17 comments
Closed

Duplicate Results #3530

byehack opened this issue Oct 25, 2022 · 17 comments
Assignees
Labels
bug Something isn't working

Comments

@byehack
Copy link

byehack commented Oct 25, 2022

image

I think it sensitive to the path. (\Lib\ and '\lib')

@Mahmood10marde
Copy link

Mahmood10marde

@rchiodo
Copy link
Contributor

rchiodo commented Oct 25, 2022

@byehack can you post the following information:

  • Version of pylance
  • Version of python extension
  • python.languageServer setting
  • Any other extensions you have installed

Duplicates are possible if you have more than one extension providing intellisense

@bschnurr
Copy link
Member

yup. do you have the pyright extension installed as well?

@byehack
Copy link
Author

byehack commented Oct 25, 2022

@bschnurr No.
@rchiodo :
python.languageServer: Default
I recently start using vscode profiles, perhaps the problem is for that?

Extension Author (truncated) Version
codesnap adp 1.3.4
vscode-fake-virtual-space Ant 0.1.3
converttoasciiart Bit 1.0.3
wwbd bre 2022.1.0
bracket-select chu 2.0.2
curlconverter cur 0.0.3
fastcompare Dav 1.1.0
python-environment-manager don 1.0.4
vscode-jupytext don 0.1.0
gitlens eam 12.2.2
py-paste-indent hye 0.3.0
vsc-python-indent Kev 1.18.0
indent-nested-dictionary mge 0.0.4
fluent-icons mig 0.0.18
compare-folders mos 0.22.3
python ms- 2022.16.0
vscode-pylance ms- 2022.10.30
jupyter ms- 2022.9.1202862440
jupyter-keymap ms- 1.0.0
jupyter-renderers ms- 1.0.10
vscode-jupyter-cell-tags ms- 0.1.6
vscode-jupyter-slideshow ms- 0.1.5
hexeditor ms- 1.9.9
material-icon-theme PKi 4.21.0
sqlite-viewer qwt 0.1.5
trailing-spaces sha 0.4.1
selectline-statusbar tom 0.0.2
errorlens use 3.6.0

(1 theme extensions excluded)

@rchiodo
Copy link
Contributor

rchiodo commented Oct 25, 2022

@byehack not sure about the profiles. I guess the thing would be to try it without.

Additionally, if you could disable all extensions except python and pylance and see if it repros still? I don't believe any of those other extensions are providing hover for python, but I could be wrong.

@byehack
Copy link
Author

byehack commented Oct 25, 2022

after extension bisect found this problem is from Jupyter extension

@byehack byehack closed this as completed Oct 25, 2022
@debonte
Copy link
Contributor

debonte commented Oct 25, 2022

Dupe of microsoft/vscode-jupyter#11038?

@byehack
Copy link
Author

byehack commented Oct 25, 2022

@debonte
image

@byehack
Copy link
Author

byehack commented Oct 25, 2022

fixed after disable jupyter.pylanceHandlesNotebooks.

@debonte
Copy link
Contributor

debonte commented Oct 25, 2022

Why do you have python.pylanceLspNotebooksEnabled disabled? Are you working around an issue there? If so, can you explain what that is? In the near future we're planning to reduce Pylance's notebooks support to effectively only allowing "python.pylanceLspNotebooksEnabled": true

@byehack
Copy link
Author

byehack commented Oct 25, 2022

I don't know what the exact issue was, but I remember about 1 month ago it has some issues, and after i disabled the python.pylanceLspNotebooksEnabled issues gone.
unfortunately, I didn't report issues at that time.

@debonte
Copy link
Contributor

debonte commented Oct 25, 2022

Ok, would you mind re-enabling it and filing any issues you run into?

If you find bugs with "python.pylanceLspNotebooksEnabled": false we're unlikely to fix them, since that is using our "legacy" notebooks support.

@byehack
Copy link
Author

byehack commented Nov 12, 2022

after update to latest version again i get duplicate results.
it seems python.pylanceLspNotebooksEnabled removed?
image

@byehack byehack reopened this Nov 12, 2022
@byehack
Copy link
Author

byehack commented Nov 12, 2022

downgraded to 2022.16.1 to get back that option and disable it for fixing this bug.

@byehack byehack closed this as completed Nov 12, 2022
@debonte
Copy link
Contributor

debonte commented Nov 14, 2022

@byehack, pylanceLspNotebooksEnabled is now always on in recent builds.

There was a recent regression in the Jupyter extension that was causing duplicates though. Can you try upgrading to the latest pre-release build of Jupyter and see if the issue goes away?

See microsoft/vscode-jupyter#11938 (comment)

@iamwxq
Copy link

iamwxq commented Nov 20, 2022

@debonte

Extension Version
Jupyter v2022.11.1003241024(pre-release)
Pylance v2022.11.30
Python v2022.18.2

After upgrading to the pre-release build of Jupyter, the problem is only partially solved:
Duplicate intellisense only appear in those variables I imported and only happen when I run the notebook once, otherwise everything works well.

before running

issue1

issue2

after running

issue3

only appear in those variables I import and other variables works well

issue4

@byehack byehack reopened this Nov 20, 2022
@debonte debonte self-assigned this Nov 21, 2022
@judej judej added bug Something isn't working and removed triage-needed labels Nov 21, 2022
@debonte
Copy link
Contributor

debonte commented Nov 21, 2022

@whoeverim5, what you're seeing is microsoft/vscode-jupyter#11038.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

7 participants