Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unparseable docstrings should fall back to the old docstring parser #6494

Open
rchiodo opened this issue Sep 30, 2024 · 0 comments
Open

Unparseable docstrings should fall back to the old docstring parser #6494

rchiodo opened this issue Sep 30, 2024 · 0 comments
Assignees
Labels
bug Something isn't working docstrings

Comments

@rchiodo
Copy link
Contributor

rchiodo commented Sep 30, 2024

We currently attempt to recover parser errors in https://github.com/microsoft/pyrx/blob/8d88e0bba6789cec3a57d3e6efad45df11873d56/packages/pylance-internal/src/common/docstring/fixer.ts#L560

This can sometimes work but there are likely an infinite number of cases that we cannot parse. In all of those cases we currently just stop showing any more output.

I think we should instead switch back to the old docstring parser and we have any unrecoverable errors.

See this issue for an example:
#6419

@rchiodo rchiodo self-assigned this Sep 30, 2024
@github-actions github-actions bot added the needs repro Issue has not been reproduced yet label Sep 30, 2024
@rchiodo rchiodo added bug Something isn't working docstrings and removed needs repro Issue has not been reproduced yet labels Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working docstrings
Projects
None yet
Development

No branches or pull requests

2 participants