Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose onHoverIn/onHoverOut on Pressable #871

Closed
Saadnajmi opened this issue Oct 27, 2021 · 2 comments
Closed

Expose onHoverIn/onHoverOut on Pressable #871

Saadnajmi opened this issue Oct 27, 2021 · 2 comments
Labels
Area: Mouse enhancement New feature or request

Comments

@Saadnajmi
Copy link
Collaborator

Summary

With facebook#32405 , The Stock Pressable component now exposes onHoverIn/onHoverOut as the way to support mouse events. We should align our desktop ports (rn-macos/windows/win32) to take advantage of this.

Motivation

This issue is motivated by my want to use the RN Stock Pressable component in FluentUI React Native, which currently has a local copy of Pressable internally. Using the upstream component would mean less custom code and smaller bundle size for FluentUI React Native. It also will help push Pressable as "the" cross platform component for handling mouse / keyboard focus / press events.

Basic Example

No response

Open Questions

No response
@Saadnajmi Saadnajmi added the enhancement New feature or request label Oct 27, 2021
@ghost ghost added the Needs: Triage 🔍 label Oct 27, 2021
@Saadnajmi Saadnajmi mentioned this issue Oct 27, 2021
Closed
@Saadnajmi
Copy link
Collaborator Author

similar windows issue: microsoft/react-native-windows#8972

@Saadnajmi Saadnajmi mentioned this issue Oct 27, 2021
Closed
@Saadnajmi
Copy link
Collaborator Author

Fixed with #884

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area: Mouse enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Saadnajmi @HeyImChris