From 61bb3fd535b93567db70813243f5a571d71cd866 Mon Sep 17 00:00:00 2001 From: Dulmandakh Date: Fri, 1 Feb 2019 12:07:30 -0800 Subject: [PATCH] ReactActivity extends FragmentActivity (#22662) Summary: In https://github.com/facebook/react-native/pull/20602, I tried to make ReactActivity to extend AppCompatActivity per Google recommendation. But import failed, now ReactActivity extends FragmentActivity which is a parent class of AppCompatActivity and step forward to extend AppCompatActivity. Pull Request resolved: https://github.com/facebook/react-native/pull/22662 Reviewed By: mdvacca Differential Revision: D13505140 Pulled By: hramos fbshipit-source-id: d4edc8dc5c606c45811c1deddf5727a47ad484d8 --- .../main/java/com/facebook/react/uiapp/RNTesterActivity.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/android/app/src/main/java/com/facebook/react/uiapp/RNTesterActivity.java b/android/app/src/main/java/com/facebook/react/uiapp/RNTesterActivity.java index ccb6aec0b7a..e7a6e8219da 100644 --- a/android/app/src/main/java/com/facebook/react/uiapp/RNTesterActivity.java +++ b/android/app/src/main/java/com/facebook/react/uiapp/RNTesterActivity.java @@ -20,9 +20,9 @@ public class RNTesterActivity extends ReactActivity { public static class RNTesterActivityDelegate extends ReactActivityDelegate { private static final String PARAM_ROUTE = "route"; private Bundle mInitialProps = null; - private final @Nullable Activity mActivity; + private final @Nullable ReactActivity mActivity; - public RNTesterActivityDelegate(Activity activity, String mainComponentName) { + public RNTesterActivityDelegate(ReactActivity activity, String mainComponentName) { super(activity, mainComponentName); this.mActivity = activity; }