Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

W3C Trace propagation via ReverseProxy #351

Closed
chandramouleswaran opened this issue Jul 27, 2020 · 2 comments
Closed

W3C Trace propagation via ReverseProxy #351

chandramouleswaran opened this issue Jul 27, 2020 · 2 comments
Labels
Type: Idea This issue is a high-level idea for discussion.

Comments

@chandramouleswaran
Copy link

What should we add or change to make your life better?

To start off - this project is awesome. I have been experimenting with this and GRPC bi-directional streaming works like a charm. For our use case, we would like to get the distributed traces emitted correctly. Today, ASP .NET Core + HttpClient make this happen seamlessly.

I think the problem is the client factory is using SocketsHttpHandler and it does not support passing trace context automatically.
dotnet/runtime#31261

Instead, if this changes to HttpClientHandler - we would end up getting the headers injected to visualize an E2E trace via the Reverse proxy. (May be - I am not very familiar with the code but this was the one which stood out)

Why is this important to you?

This is important for cases where we have to understand the calling pattern across multiple microservices in our environment.

Please let me know if this is a good idea to try out - if so, I can help out with the PR to make this change as well.

@chandramouleswaran chandramouleswaran added the Type: Idea This issue is a high-level idea for discussion. label Jul 27, 2020
@Tratcher
Copy link
Member

Yeah, we'll get this sorted out either as part of #137, or by directly fixing dotnet/runtime#31261.

@samsp-msft
Copy link
Contributor

Duplicate of #292

@samsp-msft samsp-msft marked this as a duplicate of #292 Jul 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Idea This issue is a high-level idea for discussion.
Projects
None yet
Development

No branches or pull requests

3 participants