Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only fall back to master for non-Azure connections on OE database nodes #1767

Open
Charles-Gagnon opened this issue Nov 22, 2022 · 0 comments
Labels

Comments

@Charles-Gagnon
Copy link
Contributor

We currently fall back to master for OE connections if a DB can't be found : https://github.com/microsoft/sqltoolsservice/blob/main/src/Microsoft.SqlTools.ServiceLayer/ObjectExplorer/SmoModel/DatabaseTreeNode.cs#L29

This was originally done for fixing AGs in #854 - but this should only apply for non-Azure connections. This was part of the cause of this issue : microsoft/azuredatastudio#21245 where Azure connections failed querying sys.database_service_objectives and thus fell back to master (which meant displaying the wrong tables and other objects)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant