Add XE 'Actions' into Profiler Event #2397
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lewis-sanchez
requested review from
Benjin,
aasimkhan30,
caohai,
laurennat and
lewis-sanchez
kburtram
approved these changes
Sep 23, 2024
| @@ -143,6 +143,17 @@ private Task OnEventRead(IXEvent xEvent) | |||
| { | |||
| profileEvent.Values.Add(kvp.Key, kvp.Value.ToString()); | |||
| } | |||
| // Add the XE 'actions'. | |||
| foreach (var kvp in xEvent.Actions) | |||
There was a problem hiding this comment.
I assume Actions can never be null here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2396 issue
ProfilerEventdictionary will not contain the information from the XEvent related to the 'Actions'.If we attempt to open XEL files on an app consumer of SqlToolService (ie.
Azure Data Studio) the information will miss these columns.XEvent Actions are used commonly, for example to automate generic metadata such as 'app name' 'code package version', 'timestamp', etc. Potentially any piece/kind of telemetry, hence they should not be omitted.
Example of ADS displaying the info (with local STS)
Example of ADS displaying the info (default)
at last, we chose to add a '(action)' postfix in case there is a key dup. SSMS is following this convention when displaying the info:
