Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can we exit terminal completely when command exit is called? #11179

Closed
amithegde opened this issue Sep 8, 2021 · 5 comments
Closed

Can we exit terminal completely when command exit is called? #11179

amithegde opened this issue Sep 8, 2021 · 5 comments
Labels
Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.

Comments

@amithegde
Copy link

Description of the new feature/enhancement

I usually enter command exit to exit cmd.exe or conemu which exits the process. But with terminal, it displays:

image

Now, need to grab mouse and click the close button to close it completely. Interestingly, when I have quake mode, there is no x button to close it so I need to take help from trusted friend Process Explorer to kill Terminal.

Note: this happens for the first tab, splits and other tabs seem to exit fine.

Proposed technical implementation details (optional)

  • When user enters the command exit terminal process should exit completely
@amithegde amithegde added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Sep 8, 2021
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Sep 8, 2021
@DHowett
Copy link
Member

DHowett commented Sep 8, 2021

(You can also close it with Ctrl+Shift+W.)

Over to @zadjii-msft for his cached response 😄

@elsaco
Copy link

elsaco commented Sep 9, 2021

By default "Profile termination behavior" in "Advanced" settings is "Close only when process exits successfully". By selecting first option "Close when process exits, fails, or crashes" will close a cmd.exe session without the [process exited with code 1] message.

Sample config:
wt_cmd_exit_setting

@LuanVSO
Copy link
Contributor

LuanVSO commented Sep 9, 2021

type this isntead:

exit 0

@zadjii-msft
Copy link
Member

Thanks for the report! Please make sure to search for duplicates when filing new issues. There's already a decent amount of discussion in the above issues explaining why this happens.

#4263 (comment)

This behavior exists to stop an error message printed out by a program from disappearing instantly when it exits. There is a class of applications for which that is extremely important. We're following this behavior because it is the right brhavior to follow, and because you can turn it off with a config option very easily.

#4736 (comment)

Alas, this is a behavior that's highly conserved across multiple shells and terminal emulators on most mainstream operating systems; more info in #4223 (comment). If you'd rather it just exit every time, set closeOnExit to true. 😄 /dup #4223.

And of course, as mentioned elsewhere in this thread, the closeOnExit setting can change this behavior if you're really used to using exit to close your terminal windows. You can read more about it in the docs here.

@ghost
Copy link

ghost commented Sep 9, 2021

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@ghost ghost closed this as completed Sep 9, 2021
@ghost ghost added Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Sep 9, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.
Projects
None yet
Development

No branches or pull requests

5 participants