Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WT: Load profile icons from executables #11733

Closed
alabuzhev opened this issue Nov 11, 2021 · 3 comments
Closed

WT: Load profile icons from executables #11733

alabuzhev opened this issue Nov 11, 2021 · 3 comments
Labels
Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.

Comments

@alabuzhev
Copy link
Contributor

Description of the new feature/enhancement

It's nice that WT supports custom profile icons.
It's nice that it can load jpg, png, bmp, gif, tiff and ico.

However, why doesn't it support loading icons from executables?
If I'm creating a new profile and setting its icon, usually I want it to have exactly the same icon as the underlying executable has, but I can't load it directly, so I have to either play with the Print Screen and Paint (ugh) or look for a 3rd party tool to extract an icon from the exe, because usually apps don't come with separately packaged icons, because every shortcut in Windows allows to load icons from exe, dll, etc. directly since 1995 or so.

Are there any technical limitations for that?

@alabuzhev alabuzhev added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Nov 11, 2021
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Nov 11, 2021
@zadjii-msft
Copy link
Member

There's mostly engineering time limitations for that 😋. In general, this is a dupe of:

I'm also tempted to just close out #705, because that probably will work less often than the user would hope. Being explicit about the icon is probably a better idea.

So, /dup #1504

@ghost
Copy link

ghost commented Nov 11, 2021

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@ghost ghost closed this as completed Nov 11, 2021
@ghost ghost added Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Nov 11, 2021
@alabuzhev
Copy link
Contributor Author

Thanks.

I'm also tempted to just close out #705, because that probably will work less often than the user would hope

Please don't - machines should work and it's a nice thing if the code can load the icon automatically and save the user some clicks, even if not in 100% of cases.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.
Projects
None yet
Development

No branches or pull requests

2 participants