Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command Palette should include profile names #14314

Closed
OlafvdSpek opened this issue Oct 31, 2022 · 6 comments
Closed

Command Palette should include profile names #14314

OlafvdSpek opened this issue Oct 31, 2022 · 6 comments
Labels
Area-CmdPal Command Palette issues and features Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.

Comments

@OlafvdSpek
Copy link

Ctrl-Shift-P - PowerShell returns "No matching commands". It'd be nice if it allowed you to open a new tab with the profile.

@OlafvdSpek OlafvdSpek added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Oct 31, 2022
@ghost ghost added Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Oct 31, 2022
@lhecker lhecker added Product-Terminal The new Windows Terminal. Issue-Task It's a feature request, but it doesn't really need a major design. Area-CmdPal Command Palette issues and features and removed Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. labels Nov 2, 2022
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Nov 2, 2022
@zadjii-msft zadjii-msft added Issue-Question For questions or discussion Resolution-Answered Related to questions that have been answered and removed Issue-Task It's a feature request, but it doesn't really need a major design. labels Nov 2, 2022
@zadjii-msft
Copy link
Member

zadjii-msft commented Nov 2, 2022

It totally can do this! For clarity, we've nested those commands in the "New Tab..." menu by default. You're totally free to change the structure of your command palette however you'd like! The docs site even has an example for how you might get the structure you're looking for.

@OlafvdSpek
Copy link
Author

It'd be nice if it did this by default.

@DHowett DHowett added Issue-Task It's a feature request, but it doesn't really need a major design. and removed Issue-Question For questions or discussion Resolution-Answered Related to questions that have been answered labels Nov 2, 2022
@DHowett
Copy link
Member

DHowett commented Nov 2, 2022

I definitely agree with @OlafvdSpek here. There's a disconnect between what the settings model stores for actions (like, they contain a profile index) and how the user thinks about those actions (they act on a profile).

If I may spin a tale for a second to illustrate the counterpoint... if we take the "index is primary" stance to its logical conclusion, Terminal would look like this:

image

@zadjii-msft
Copy link
Member

There's been some debate about this in the past: Unified keybindings and commands, and synthesized action names.md, #6532 (comment), #7016. Move this discussion to that thread?

@zadjii-msft
Copy link
Member

/dup #7016

@zadjii-msft zadjii-msft closed this as not planned Won't fix, can't repro, duplicate, stale Nov 2, 2022
@ghost
Copy link

ghost commented Nov 2, 2022

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@ghost ghost closed this as completed Nov 2, 2022
@ghost ghost added Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Nov 2, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-CmdPal Command Palette issues and features Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.
Projects
None yet
Development

No branches or pull requests

4 participants