Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for different appearance when running as Administrator #14593

Closed
trajano opened this issue Dec 22, 2022 · 4 comments
Closed

Allow for different appearance when running as Administrator #14593

trajano opened this issue Dec 22, 2022 · 4 comments
Labels
Area-Settings Issues related to settings and customizability, for console or terminal Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Product-Terminal The new Windows Terminal. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.

Comments

@trajano
Copy link

trajano commented Dec 22, 2022

Description of the new feature/enhancement

Although we have that smallish icon on the top left to remind us that we're running at Admin (Win-X Terminal Admin). It would be nice if we had the capability of having a different background, font, etc. to have a larger reminder that we're in Admin mode.

Proposed technical implementation details (optional)

Doesn't have to be in the UI immediately, but I am thinking so that there's not too much duplication we'd have something like

        "list": 
        [
            {
                "backgroundImage": "C:\\Users\\trajano\\Desktop\\terminal-3.jpg",
                "backgroundImageOpacity": 0.51000000000000001,
                "commandline": "C:/Program Files/Git/usr/bin/bash.exe -i -l",
                "guid": "{00000000-0000-0000-ba54-000000000001}",
                "icon": "C:\\Users\\trajano\\OneDrive\\Icons\\shebang.png",
                "name": "Bash",
                "startingDirectory": "%UserProfile%",
                "tabTitle": "..."
                "administratorOverride: {
                  "guid": "{00000000-0000-0000-ba54-000000000001}", // <-- THIS IS NOT ALLOWED

                  // this is an example of a change
                 "backgroundImage": "C:\\Users\\trajano\\Desktop\\terminal-admin.jpg",
                  "name": "Bash In ADMIN BE VERY CAREFUL",

                 // the rest are not needed if they're the same.  However I don't see a technical reason why 
                 // you won't allow changes to even the command line etc even though it will be silly for the user               
                  "backgroundImageOpacity": 0.51000000000000001,
                  "commandline": "C:/Program Files/Git/usr/bin/bash.exe -i -l",
                  "icon": "C:\\Users\\trajano\\OneDrive\\Icons\\shebang.png",
                  "startingDirectory": "%UserProfile%",
             }
            },
@trajano trajano added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Dec 22, 2022
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Dec 22, 2022
@trajano trajano changed the title Allow for different profile when running as Administrator Allow for different appearance when running as Administrator Dec 22, 2022
@PankajBhojwani
Copy link
Contributor

PankajBhojwani commented Dec 22, 2022

Huh, we don't seem to have a pre-existing thread for this so this will be it then!

We have discussed this as a team before and it is something we really want to implement - the problem we are looking to solve is the potential combinatorial explosion of having too many appearance types. For example, we currently support a 'default' and an 'unfocused' appearance, if we also support admin appearance we will have 'admin-default' 'admin-unfocused' on top of that.

And if we want to support even further appearance types in the future (say, 'high contrast mode') then we have 'unfocused-high contrast', 'admin-unfocused-high contrast' ... and so on. Until we figure out a clean solution to that problem we are holding off on adding more appearance config options.

@PankajBhojwani PankajBhojwani added Area-Settings Issues related to settings and customizability, for console or terminal Product-Terminal The new Windows Terminal. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Dec 22, 2022
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Dec 22, 2022
@PankajBhojwani PankajBhojwani added this to the Backlog milestone Dec 22, 2022
@PankajBhojwani PankajBhojwani added the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Dec 22, 2022
@j4james
Copy link
Collaborator

j4james commented Dec 22, 2022

See also #3246 and #8311.

@zadjii-msft
Copy link
Member

Good find!

/dup #3246
/dup #8311

@ghost
Copy link

ghost commented Jan 3, 2023

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@zadjii-msft zadjii-msft removed this from the Backlog milestone Jan 3, 2023
@ghost ghost closed this as completed Jan 3, 2023
@ghost ghost added Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Jan 3, 2023
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Settings Issues related to settings and customizability, for console or terminal Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Product-Terminal The new Windows Terminal. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.
Projects
None yet
Development

No branches or pull requests

4 participants