Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish the SSH profile generator #15007

Open
1 of 3 tasks
McLavish opened this issue Mar 17, 2023 · 6 comments
Open
1 of 3 tasks

Finish the SSH profile generator #15007

McLavish opened this issue Mar 17, 2023 · 6 comments
Labels
Area-Settings Issues related to settings and customizability, for console or terminal Help Wanted We encourage anyone to jump in on these. Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal.
Milestone

Comments

@McLavish
Copy link

McLavish commented Mar 17, 2023

maintainer note: hijacking OP to put tasks in here

Originally tracked in #9031
Added in #14042

Tasks

  1. help wanted
    nguyen-dows

Windows Terminal version

1.17.1023

Windows build number

10.0.22621.1413

Other Software

OpenSSH_for_Windows_8.6p1
LibreSSL 3.4.3

Steps to reproduce

  1. Install Windows Terminal (Preview) through the Microsoft Store
  2. Install the OpenSSH client from Windows Optional Features
  3. Create a user OpenSSH config file under %userprofile%.ssh\config:
Host myhost  
    HostName something.domain.com  
    User myuser  
    IdentityFile "C:\Users\myuser\myfolder\id_rsa"
  1. (Optional) Add "disabledProfileSources" : [ ], to settings.json
  2. Open Windows Terminal (Preview)

Note: It appears adding "disabledProfileSources" : [ "Windows.Terminal.SSH" ], produces a Value not accepted warning in VsCode as it's not listed in the profiles schema DynamicProfileSource enum.
bug

Expected Behavior

Docs says that "Windows Terminal version 1.XX+ can dynamically generate profiles to connect to the SSH hosts within your OpenSSH config file"

Actual Behavior

Nothing happens

@McLavish McLavish added Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Mar 17, 2023
@elsaco
Copy link

elsaco commented Mar 18, 2023

@McLavish the feature might not be enabled, yet. See details at;

terminal/src/features.xml

Lines 141 to 146 in b9248fa

<feature>
<name>Feature_DynamicSSHProfiles</name>
<description>Enables the dynamic profile generator for OpenSSH config files</description>
<id>9031</id>
<stage>AlwaysDisabled</stage>
</feature>

You could enable it using a branding token and build the terminal. I use dev token and it does generate an SSH profile:

wt_ssh_profile

To my surprise clicking on that profile opened a SSH connection to a Pi4 box, no errors!

@McLavish
Copy link
Author

@elsaco I guess you're right but then it shouldn't be listed as a feature in the windows terminal docs

image

@zadjii-msft zadjii-msft changed the title ssh dynamic profiles not generating Finish the SSH profile generator Mar 22, 2023
@carlos-zamora carlos-zamora added this to the Terminal v1.19 milestone Mar 22, 2023
@nguyen-dows
Copy link
Contributor

nguyen-dows commented Mar 22, 2023

@McLavish I agree. There is already been an issue made to get this removed from the docs page which I've assigned myself too: MicrosoftDocs/terminal#641

Thanks for including the screenshot and link to the doc!

@zadjii-msft
Copy link
Member

You know what, good callout. We should remove this from the docs until we ship this. Clearly our docs need some love 😅

I'm gonna hijack your OP to track the rest of the work needed to get this across the finish line.

@zadjii-msft zadjii-msft added Help Wanted We encourage anyone to jump in on these. Product-Terminal The new Windows Terminal. Issue-Task It's a feature request, but it doesn't really need a major design. and removed Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Mar 22, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Tag-Fix Doesn't match tag requirements label Mar 22, 2023
@zadjii-msft zadjii-msft added the Area-Settings Issues related to settings and customizability, for console or terminal label Mar 22, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs-Tag-Fix Doesn't match tag requirements label Mar 22, 2023
@zadjii-msft zadjii-msft modified the milestones: Terminal v1.20, Backlog Oct 4, 2023
@rmdes
Copy link

rmdes commented Dec 7, 2023

Any chance this is working now ?

@zadjii-msft
Copy link
Member

Nope. The issue is still open. We haven't really had the time to loop back around on this one. We'd love the help if you're interested though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Settings Issues related to settings and customizability, for console or terminal Help Wanted We encourage anyone to jump in on these. Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal.
Projects
None yet
Development

No branches or pull requests

6 participants