Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Portable Mode] Reference files (i.e. images) near settings.json #15374

Closed
carlos-zamora opened this issue May 17, 2023 · 1 comment
Closed
Labels
Area-Settings Issues related to settings and customizability, for console or terminal Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal.

Comments

@carlos-zamora
Copy link
Member

Prior to portable mode, a common heuristic to reference images would be to use ms-appdata:///Local. However, portable mode promises a terminal that is essentially fully encapsulated in a separate folder (i.e. a flash drive). There should be a way to reliably reference images and files in that flash drive.

The issue at hand is that the flash drive may not be reliably set as the D: drive.

For example, I have the following json in a profile:

                "backgroundImage": "ms-appdata:///Local/ubuntu_bg.png",

If the terminal is in portable mode, (I suspect) this won't work.

Ideally, I could store ubuntu_bg.png in the settings folder (next to the settings.json file).

@carlos-zamora carlos-zamora added Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Area-Settings Issues related to settings and customizability, for console or terminal Product-Terminal The new Windows Terminal. labels May 17, 2023
@carlos-zamora carlos-zamora added this to the Terminal v1.19 milestone May 17, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label May 17, 2023
@carlos-zamora carlos-zamora removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label May 17, 2023
@carlos-zamora
Copy link
Member Author

ms-appx:/// resolves to where the wt.exe is stored. So ms-appx:///settings/foo.png should work!

@carlos-zamora carlos-zamora closed this as not planned Won't fix, can't repro, duplicate, stale May 17, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Tag-Fix Doesn't match tag requirements label May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Settings Issues related to settings and customizability, for console or terminal Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal.
Projects
None yet
Development

No branches or pull requests

1 participant