Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New console screen buffer contains scroll from main buffer #17669

Closed
2trvl opened this issue Aug 6, 2024 · 2 comments
Closed

New console screen buffer contains scroll from main buffer #17669

2trvl opened this issue Aug 6, 2024 · 2 comments
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Attention The core contributors need to come back around and look at this ASAP. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting

Comments

@2trvl
Copy link

2trvl commented Aug 6, 2024

Windows Terminal version

1.20.11781.0

Windows build number

10.0.19045.4651

Other Software

hAlternateConsoleOutput = create_console_screen_buffer(
    GENERIC_READ | GENERIC_WRITE,
    FILE_SHARE_READ | FILE_SHARE_WRITE,
    CONSOLE_TEXTMODE_BUFFER
)

Steps to reproduce

Enter commands in the main buffer until scrolling appears. Create a new console screen buffer.

Expected Behavior

Empty console screen without scrollback

image

Actual Behavior

Scroll up to the top and see the commands you entered in the main buffer.

image

In some cases, the last command also goes to a new screen buffer.

image

@2trvl 2trvl added Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Aug 6, 2024
@DHowett
Copy link
Member

DHowett commented Aug 6, 2024

This may have been addressed by #17510; Can you try the Canary version of Terminal?

@DHowett DHowett added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Aug 6, 2024
@2trvl
Copy link
Author

2trvl commented Aug 6, 2024

In this case I see full compliance between virtual codes and console API methods, good job.

image

@2trvl 2trvl closed this as completed Aug 6, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention The core contributors need to come back around and look at this ASAP. and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Attention The core contributors need to come back around and look at this ASAP. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting
Projects
None yet
Development

No branches or pull requests

2 participants