Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terminal crashes when the window width is too small #2045

Closed
driver1998 opened this issue Jul 20, 2019 · 4 comments · Fixed by #2118
Closed

Terminal crashes when the window width is too small #2045

driver1998 opened this issue Jul 20, 2019 · 4 comments · Fixed by #2118
Assignees
@zadjii-msft
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. Severity-Crash Crashes are real bad news.
Milestone
Terminal v0.3

Comments

@driver1998
Copy link

Environment

Windows build number: [run "ver" at a command prompt] 10.0.18941.1001
Windows Terminal version (if applicable): commit 5074335392c14d3359280609c8a03166cc20b857

Any other software?

Steps to reproduce

Open Windows Terminal, and resize the window, when the window width is smaller than a certain value, it crashes.
out

Expected behavior

It should not crash.

Actual behavior

It crashes.
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Jul 20, 2019
@driver1998 driver1998 changed the title Terminal crashes when the window is too small Terminal crashes when the window width is too small Jul 20, 2019
@vblazhkun
Copy link

@driver1998 I have the same issue and have two core dumps waiting to be uploaded.

@vblazhkun vblazhkun mentioned this issue Jul 22, 2019
Closed
@mcpiroman
Copy link
Contributor

It strongly seems to be regression caused by #1948.

@DHowett-MSFT DHowett-MSFT added Area-User Interface Issues pertaining to the user interface of the Console or Terminal Product-Terminal The new Windows Terminal. Severity-Crash Crashes are real bad news. Issue-Bug It either shouldn't be doing this or needs an investigation. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Jul 22, 2019
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Jul 22, 2019
@DHowett-MSFT
Copy link
Contributor

We can reproduce this here, so we probably don't need any dumps. Thanks!

@zadjii-msft zadjii-msft mentioned this issue Jul 26, 2019
Merged
3 tasks
@ghost ghost added the In-PR This issue has a related PR label Jul 26, 2019
@ghost ghost added Needs-Tag-Fix Doesn't match tag requirements Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Jul 26, 2019
@ghost
Copy link

ghost commented Aug 3, 2019

🎉This issue was addressed in #2118, which has now been successfully released as Windows Terminal Preview v0.3.2142.0.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zadjii-msft zadjii-msft

Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. Severity-Crash Crashes are real bad news.
Projects
None yet
Milestone
Terminal v0.3
Development

Successfully merging a pull request may close this issue.

Prevent a crash on resizing too small caused by the Titlebar microsoft/terminal
5 participants
@vblazhkun @DHowett-MSFT @zadjii-msft @driver1998 @mcpiroman