Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terminal doesn't resize if historySize is set to ~32700 or larger #3599

Closed
sphennings opened this issue Nov 15, 2019 · 3 comments
Closed

Terminal doesn't resize if historySize is set to ~32700 or larger #3599

sphennings opened this issue Nov 15, 2019 · 3 comments
Labels
Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.

Comments

@sphennings
Copy link

Environment

Windows build number: Microsoft Windows NT 10.0.18362.0
Windows Terminal version: 0.6.2951.0

Steps to reproduce

  1. Set the historySize of a terminal profile to a sufficiently large number. (I modified the default profiles in my testing)
  • 32747 or larger for powershell
  • 32797 or larger for wsl
  1. Create a new terminal tab using the modified profile
  2. Record the current reported terminal size
  • Use $Host.UI.RawUI.WindowSize.Width; $Host.UI.RawUI.WindowSize.Height for powershell
  • Use tput cols; tput lines for wsl
  1. Resize the terminal window
  2. Record the new reported terminal size

Expected behavior

Resizing the terminal window should change the reported terminal dimensions.

Terminal resize behavior should be unaffected by historySize.

Actual behavior

When the historySize profile setting is sufficiently large resizing the terminal window does not change the reported terminal dimensions.

@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Nov 15, 2019
@egmontkob
Copy link

Is this perhaps the same as #2815?

@zadjii-msft
Copy link
Member

Yea this looks like a /dup of #2815. Thanks for the early triage pass @egmontkob!

@ghost
Copy link

ghost commented Nov 18, 2019

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@ghost ghost closed this as completed Nov 18, 2019
@ghost ghost added Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Nov 18, 2019
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.
Projects
None yet
Development

No branches or pull requests

3 participants