Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Additional Testing for UiaTextRange #4421

Open
2 of 5 tasks
carlos-zamora opened this issue Jan 30, 2020 · 0 comments
Open
2 of 5 tasks

Additional Testing for UiaTextRange #4421

carlos-zamora opened this issue Jan 30, 2020 · 0 comments
Assignees
@carlos-zamora
Labels
Area-Accessibility Issues related to accessibility Area-CodeHealth Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc. Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal.
Milestone
Engineering Impro...

Comments

@carlos-zamora
Copy link
Member

carlos-zamora commented Jan 30, 2020 •
edited
Loading

Description of the new feature/enhancement

After #4018, more tests were added to UiaTextRange. However, there are still gaps in our testing and they require some more thought and additional refactoring. Here's some that I have in mind:

  • MoveByWord
  • MoveEndpointByUnitWord
  • FindText
  • GetBoundingRectangles
  • GetText

The word navigation tests are currently relying more on the tests within TextBuffer. So they might not need to be as cumbersome.

FindText relies on our search module so that also isn't a high priority.

This is more of an opportunity to compare our accessibility model to others' and make sure we're not doing anything wonky (and preventing us from getting to that point).

These new tests also serve as a good opportunity to use TEST_METHOD_PROPERTY. Ideally, we could just have a standard set of tests across all text units and just iterate through those units.
@carlos-zamora carlos-zamora added Area-Accessibility Issues related to accessibility Product-Terminal The new Windows Terminal. Issue-Task It's a feature request, but it doesn't really need a major design. Area-CodeHealth Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc. labels Jan 30, 2020
@ghost ghost added the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Jan 30, 2020
@DHowett-MSFT DHowett-MSFT added this to the Terminal Backlog milestone Jan 31, 2020
@DHowett-MSFT DHowett-MSFT removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Jan 31, 2020
@carlos-zamora carlos-zamora mentioned this issue Feb 11, 2020
Closed
22 tasks
@carlos-zamora carlos-zamora self-assigned this May 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@carlos-zamora carlos-zamora

Labels
Area-Accessibility Issues related to accessibility Area-CodeHealth Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc. Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
Engineering Improvements
Development

No branches or pull requests
3 participants
@carlos-zamora @DHowett-MSFT @zadjii-msft