Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exiting a console doesn't close the tab or window #460

Closed
ObsidianMinor opened this issue May 7, 2019 · 7 comments
Closed

Exiting a console doesn't close the tab or window #460

ObsidianMinor opened this issue May 7, 2019 · 7 comments
Labels
Help Wanted We encourage anyone to jump in on these. Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work.
Milestone

Comments

@ObsidianMinor
Copy link

  • Windows build number: 10.0.18362.30

  • What's happening: Exiting a console via an exit command doesn't close the tab or window. Instead the tab or window just hangs until you manually close it.
    image

  • What should be happening: The tab or window should close upon exit

@JBanks
Copy link
Contributor

JBanks commented May 7, 2019

For tabs, make sure that you have "closeOnExit": true, as a setting in the particular profile.
This only works if you have more than one tab open.

@Flipp3rrr
Copy link

In my opinion "closeOnExit": true should be turned on by default. This behaviour is a little bit weird.

@bef178
Copy link
Contributor

bef178 commented May 8, 2019

And ctrl-w closes the tab currently

@isaacrlevin
Copy link

To compound on this, I would expect if I exit with only one tab, Terminal should close as well.

@zadjii-msft
Copy link
Member

Yea, closeOnExit should probably default to true. This would be a fairly good starter issue if someone wanted to make a PR :)

Closing the terminal when the last tab is closed is also something we should be doing, but that might be a bit trickier of a PR. I think we're manually suppressing the close action on the last tab currently, but that could be replaced with just closing the app (somehow).

@zadjii-msft zadjii-msft added this to the Windows Terminal v1.0 milestone May 8, 2019
@zadjii-msft zadjii-msft added Help Wanted We encourage anyone to jump in on these. Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. labels May 8, 2019
@JBanks
Copy link
Contributor

JBanks commented May 9, 2019

Closing the terminal when the last tab is closed is also something we should be doing, but that might be a bit trickier of a PR. I think we're manually suppressing the close action on the last tab currently, but that could be replaced with just closing the app (somehow).

@zadjii-msft, should we open a separate issue for this, or re-open this one until the second piece is resolved?

@zadjii-msft
Copy link
Member

A second issue is probably best. Filed #627 to track it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Help Wanted We encourage anyone to jump in on these. Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work.
Projects
None yet
Development

No branches or pull requests

6 participants