-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using different GUIDs for profiles that use "source" cause them to not be found by Terminal. #5490
Comments
Same here! After the update my Ubuntu profile wasn't the default anymore (even with the correct guid on defaultProfile property). Thanks to @TechPreacher for highlighting the source/commandline thing, it did the trick for me (for now). For those looking for a quick local fix: Current (and stock) settings that can't be set as default:
Fixed:
p.s: I'm not running any insider build, I'm assuming these changes might need to be reverted once we have the 2004 build. |
That’s not what source does, and is absolutely not going to improve your situation. Source is an indicator as to which component of Terminal created the profile. That component, which we call the “generator,” sets various properties like the command line and name and color scheme for you to override. Switching the GUID of a profile that has a generator will make it so the generator cannot find the existing profile and has to make a new one with different settings. Switching up the guid and keeping the source field will also make your profile disappear: Terminal believes that it was automatically generated and because the generator can’t attest to its existence, it’s assumed that it no longer exists. (This is how old WSL distributions disappear from your profile list even though they’re still in your settings file with your customizations saved.) If your defaultProfile stopped working, you probably want #5458. |
Now that I'm at my computer (sorry: prior message was terse because it was written on my phone)... So, this deserves some real documentation. Here's the deal:
|
@DHowett-MSFT thanks for clarifying. It makes complete sense, it was just under-documented, or I didn't find it. In my old settings I had all my profiles with "commandline" and saw that it also works - much cleaner in my opinion - with "source". That's why I took my old profiles that had a some customization (titles, icons etc.) and replaced "commandline" with "source", which is where the trouble started. I now use all the default profiles that use "source" and just keep my custom made one for Git Bash around, which works perfectly.
|
I’ll make sure our documentation’s clearer about sources and how to deal with dynamic profiles while we don’t have a setting UI. Thanks a bunch :) |
Environment
Steps to reproduce
This is only true for all the profiles using a "source" instead of a "commandline" parameter to start the shell.
Expected behavior
Terminal accepts any vaild GUID for any type of profile and starts or lists it in the list of profiles OR clearly documents that profiles need to have a specific GUID.
Actual behavior
The text was updated successfully, but these errors were encountered: