Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure that key bindings work in all IMEs #6439

Closed
yola-0316 opened this issue Jun 9, 2020 · 17 comments
Closed

Make sure that key bindings work in all IMEs #6439

yola-0316 opened this issue Jun 9, 2020 · 17 comments
Labels
Area-i18n Internationalization issues (e.g.: non-US input handling doesn't work) Area-Input Related to input processing (key presses, mouse, etc.) Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-1 A description (P1) Product-Terminal The new Windows Terminal. Resolution-By-Design It's supposed to be this way. Sometimes for compatibility reasons.

Comments

@yola-0316
Copy link

yola-0316 commented Jun 9, 2020

Environment

Windows build number: [run `[Environment]::OSVersion` for powershell, or `ver` for cmd]  
Platform ServicePack Version      VersionString 
-------- ----------- -------      ------------ 
Win32NT             10.0.19041.0 Microsoft Windows NT 10.0.19041.0

Windows Terminal version (if applicable):
1.0.1401.0

Any other software?

Steps to reproduce

ctrl+, open settings.json, find keybindings tutorial in microsoft docs
modify some keybindings like that:

{ "command": "openNewTabDropdown", "keys": "ctrl+shift+d" },        // will work
{ "command": "openNewTabDropdown", "keys": "ctrl+shift+space" }, // not work

 { "command": { "action": "newTab", "index": 0 }, "keys": "ctrl+1" },     // will work
 { "command": { "action": "newTab", "index": 1 }, "keys": "ctrl+2" },     // will work
 { "command": { "action": "newTab", "index": 2 }, "keys": "ctrl+shift+3" },     // not work
 { "command": { "action": "newTab", "index": 3 }, "keys": "ctrl+shift+4" },     // not work

Expected behavior

keybindings work properly

Actual behavior

some keybindings not work

settings.json

GitHub not support upload .json file, modify the extension to .txt
settings.txt

@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Jun 9, 2020
@DHowett
Copy link
Member

DHowett commented Jun 10, 2020

This is strange!
What keyboard layout are you using?

@DHowett DHowett added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Jun 10, 2020
@yola-0316
Copy link
Author

yola-0316 commented Jun 10, 2020


Resolved!
Conflicted with other shortcuts.
ctrl+shift+space conflict with IME shortcut ctrl+space Chinese/English mode toggle.
ctrl+shift+NUMBER, when I quit the most app, it worked, I need to find which app affected.
Wish to have some notify when keybindings have used by another application.


@DHowett I use US keyboard layout.
Just now, I discovered the effect of input methods on keybindings.
When I switch IME to English US. One of the keybindings worked.
微信截图_20200610134908

{ "command": "openNewTabDropdown", "keys": "ctrl+shift+d" },        // will work
{ "command": "openNewTabDropdown", "keys": "ctrl+shift+space" }, // will work under English US

but this still not work

 { "command": { "action": "newTab", "index": 2 }, "keys": "ctrl+shift+3" },     // not work  
 { "command": { "action": "newTab", "index": 3 }, "keys": "ctrl+shift+4" },     // not work

Before, I used the English status of Chinese input
微信截图_20200610135602
It may be that the input method has affected keybinds?

@ghost ghost added Needs-Attention The core contributors need to come back around and look at this ASAP. and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Jun 10, 2020
@DHowett
Copy link
Member

DHowett commented Jun 10, 2020

I will reopen this issue, because we want to make sure that key bindings work in all IMEs :)

@DHowett DHowett reopened this Jun 10, 2020
@zadjii-msft zadjii-msft added Area-Input Related to input processing (key presses, mouse, etc.) Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-1 A description (P1) Product-Terminal The new Windows Terminal. and removed Needs-Attention The core contributors need to come back around and look at this ASAP. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Jun 10, 2020
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Jun 10, 2020
@zadjii-msft zadjii-msft added this to the Terminal v2.0 milestone Jun 10, 2020
@plastikfan

This comment has been minimized.

@JonathanBergendahl

This comment has been minimized.

@zadjii-msft

This comment has been minimized.

@zadjii-msft zadjii-msft changed the title Some keybinds not work. Make sure that key bindings work in all IMEs May 6, 2021
@JonathanBergendahl

This comment has been minimized.

@zadjii-msft

This comment has been minimized.

@JonathanBergendahl

This comment has been minimized.

@zadjii-msft

This comment has been minimized.

@JonathanBergendahl

This comment has been minimized.

@zadjii-msft

This comment has been minimized.

@JonathanBergendahl

This comment has been minimized.

@zadjii-msft

This comment has been minimized.

@zadjii-msft zadjii-msft modified the milestones: Terminal v2.0, 22H1 Jan 4, 2022
@zadjii-msft zadjii-msft modified the milestones: 22H1, Terminal v1.14 Feb 2, 2022
@zadjii-msft zadjii-msft added the Area-i18n Internationalization issues (e.g.: non-US input handling doesn't work) label Feb 3, 2022
@zadjii-msft zadjii-msft modified the milestones: Terminal v1.14, 22H2 Mar 10, 2022
@lhecker
Copy link
Member

lhecker commented Mar 13, 2022

Just now, I discovered the effect of input methods on keybindings.
When I switch IME to English US. One of the keybindings worked.

I think that part should work now with the introduction of #10876, which was released in Windows Terminal 1.11.

@zadjii-msft zadjii-msft modified the milestones: 22H2, Backlog Jul 5, 2023
@zadjii-msft
Copy link
Member

(also cross-linking: #15598. ctrl+shift+f for find doesn't work with the Microsoft Pinyin IME)

@zadjii-msft zadjii-msft added the Needs-Discussion Something that requires a team discussion before we can proceed label Mar 29, 2024
@zadjii-msft zadjii-msft added Resolution-By-Design It's supposed to be this way. Sometimes for compatibility reasons. and removed Needs-Discussion Something that requires a team discussion before we can proceed labels Jun 10, 2024
@zadjii-msft
Copy link
Member

We discussed this a little while back, and we've come to the conclusion as a team that it's going to be practically impossible for us to avoid conflicts with all keys bound in all possible software that someone might be using with the Terminal. We will try our best to stick to ctrl+shift modifiers for keys we bind in our default settings, to avoid conflicts with CLI apps. And we'll always let users change bindings for keys on their own. But there's not much else we can do here to try and avoid the gambit of other things that might also bind keys.

@zadjii-msft zadjii-msft closed this as not planned Won't fix, can't repro, duplicate, stale Jun 10, 2024
@zadjii-msft zadjii-msft removed this from the Backlog milestone Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-i18n Internationalization issues (e.g.: non-US input handling doesn't work) Area-Input Related to input processing (key presses, mouse, etc.) Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-1 A description (P1) Product-Terminal The new Windows Terminal. Resolution-By-Design It's supposed to be this way. Sometimes for compatibility reasons.
Projects
None yet
Development

No branches or pull requests

6 participants