-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Find command doesn't reset search text if Find box is open #8671
Comments
@zadjii-msft - welcome back man! 😊 |
@Don-Vito Thanks! I'm mostly thinking about the
solution. That's probably what we'd want to do here. |
@zadjii-msft - wait... 😄 probably I don't know what select all means.. because as of 1.4 (or even earlier) we do select all the text in the searchbox when invoking the find command. I think that the main problem in this ticket is that we didn't receive commands when search box is in focus (resolved by #8586). |
Looks like if I click with mouse on terminal to move focus out of FindBox, and press FindCommand keys it focused FindBox again and selects all text, but if I never leave FindBox and press FindCommand keys again nothing happens. |
@DavidKarlas - thanks! It makes sense. We had a defect that when you are focusing on the FindBox the shortcuts are not executed. So when you press FindCommand keys or shortcut of every other command nothing happens (when focused on the FindBox try to click ctrl-shift-p to see that the command palette is not open as well). We fixed it here: #8586. |
Ahhhhh okay yep, that makes sense. I'll close this one as a dupe, since they had the same root cause. /dup #6679 Thanks! |
Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report! |
Yep its seems to be same issue, Ctrl+Shift+P also doesn't have effect... Is there any preview/internals channel that has this fix? |
@DavidKarlas - not that I am aware of (beyond building from source code).. |
We don't really have a more specific timeline to share for 1.6 other than "later in January" - there's a longer release cycle here because of the long holidays. Otherwise it's usually about once a month. |
Environment
Steps to reproduce
Execute "find" command, default keybinding is "ctrl+shift+f".
Type "hello".
Execute "find" command again, default keybinding is "ctrl+shift+f".
Type "world".
Expected behavior
Find box opened with text "world" in it.
Actual behavior
Find box opened with text "helloworld" in it.
Why do I think this bug? Because this is behavior of most applications. e.g: Edge, Visual Studio, Visual Studio Code...
I think easiest and most correct fix would be to "select all" text when Find command in executed and FindBox is already opened.
The text was updated successfully, but these errors were encountered: